[feature] SC-166737/improve app proxy security by restricting where token replacements can go #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken replacements can go
|
Build for commit 27ea6e9 deployed to: https://woocommerce-pr-53.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a settingsInjection configuration to the WooCommerce app manifest to enable server-side injection of API credentials into request headers. This moves authentication handling from client-side template strings to proxy-level injection for improved security.
- Introduced
settingsInjectionblock in the proxy whitelist configuration - Configured
consumer_keyandconsumer_secretto be injected into theAuthorizationheader for WooCommerce API endpoints
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…oken replacements can go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the API configuration in the
manifest.jsonfile to support injecting WooCommerce API credentials into request headers. This makes authentication more flexible and secure.Authentication improvements:
settingsInjectionblock to the API endpoint configuration, allowingconsumer_keyandconsumer_secretto be injected into theAuthorizationheader for requests towp-json/wc/v3/.*.