-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Deps #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade Deps #75
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR upgrades a set of production and development dependencies in package.json (and corresponding lockfile) to newer patch/minor versions, without changing application code or scripts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:63` </location>
<code_context>
"intersection-observer": "^0.12.2",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "2.8.7",
"react-resize-observer": "^1.1.1",
</code_context>
<issue_to_address>
**issue (bug_risk):** Version mismatch between Jest core (29.x) and jest-environment-jsdom (30.x) may cause runtime/test issues.
`jest` is pinned at 29.7.0 while `jest-environment-jsdom` is now 30.2.0 (different major). Jest environments are generally expected to match the core major version, and this mismatch can cause config incompatibilities or runtime errors in tests. Consider either staying on a 29.x environment or upgrading Jest (and related packages) to 30.x in the same change.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit 846a8af deployed to: https://sage-pr-75.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates multiple dependencies in the project to newer versions, focusing on both production and development packages. The changes include updates to core libraries like the Deskpro SDK, Sentry monitoring tools, React form handling, and build/test tooling to ensure the project stays current with security patches and latest features.
Key changes:
- Updated production dependencies including @deskpro/app-sdk (6.0.6 → 6.0.8), @sentry/react (9.38.0 → 9.47.1), and react-hook-form (7.60.0 → 7.70.0)
- Updated build and test tooling including TypeScript (5.8.3 → 5.9.3), @swc/core (1.12.14 → 1.15.8), and vite (6.3.6 → 6.4.1)
- Lockfile changes reflect proper dependency resolution with updated transitive dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated version specifications for 16 production and development dependencies |
| pnpm-lock.yaml | Automatically generated lockfile with resolved dependency tree reflecting all version updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies in the
package.jsonfile, bringing both production and development packages to newer versions. These updates help ensure compatibility, security, and access to the latest features and bug fixes.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query,react-hook-form,react-router-dom, andstyled-components.@swc/core,@swc/helpers,@testing-library/jest-dom,@types/lodash,@types/react,jest-environment-jsdom,ts-jest,typescript, andvite. [1] [2]Summary by Sourcery
Update application and tooling dependencies to their latest compatible versions.
Enhancements:
Build: