Upgrade Deps #71
Open
Upgrade Deps #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR upgrades multiple runtime and development dependencies in package.json (and the lockfile) to newer minor/patch versions, primarily for bug fixes, security patches, and tooling improvements, without changing application code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The upgrade to
styled-components@6.2.0while keeping@types/styled-components@5.xmay cause type conflicts, since v6 ships its own types and the DefinitelyTyped package is meant for v5; consider removing the@typespackage or aligning the versions explicitly. jest-environment-jsdomhas been bumped to30.xwhilejestremains on29.x, which is a major-version mismatch and may lead to runtime issues; it would be safer to keep them on compatible major versions.- Given the TypeScript and Vite minor/patch upgrades (
typescript@5.9.x,vite@6.4.x), it’s worth checking that your existing TS and Vite config options are still valid and not using any deprecated or renamed settings to avoid subtle build or type-check regressions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The upgrade to `styled-components@6.2.0` while keeping `@types/styled-components@5.x` may cause type conflicts, since v6 ships its own types and the DefinitelyTyped package is meant for v5; consider removing the `@types` package or aligning the versions explicitly.
- `jest-environment-jsdom` has been bumped to `30.x` while `jest` remains on `29.x`, which is a major-version mismatch and may lead to runtime issues; it would be safer to keep them on compatible major versions.
- Given the TypeScript and Vite minor/patch upgrades (`typescript@5.9.x`, `vite@6.4.x`), it’s worth checking that your existing TS and Vite config options are still valid and not using any deprecated or renamed settings to avoid subtle build or type-check regressions.
## Individual Comments
### Comment 1
<location> `package.json:71` </location>
<code_context>
"intersection-observer": "^0.12.2",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"node-fetch": "^3.3.2",
"prettier": "^2.8.8",
</code_context>
<issue_to_address>
**issue (bug_risk):** Align `jest-environment-jsdom` major version with the core Jest version.
We’re still on Jest 29.x while `jest-environment-jsdom` is now 30.x. These packages are meant to stay on the same major version, and mismatching them can cause subtle runtime/config issues. Please either keep `jest-environment-jsdom` on a 29.x-compatible version or upgrade Jest to 30.x as well.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request updates multiple dependencies to their latest versions, including both runtime and development dependencies. The changes are focused on minor and patch version updates across the dependency tree, with no apparent major version updates that would introduce breaking changes.
Key Changes:
- Core dependencies upgraded: @deskpro packages, Sentry SDK, React Query, form libraries
- Development tooling updated: TypeScript, SWC, Vite, Jest, and type definitions
- All changes appear to be minor/patch version updates within compatible ranges
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency version specifiers for 20+ packages (both runtime and dev dependencies) |
| pnpm-lock.yaml | Reflects the resolved dependency tree with updated versions and transitive dependencies |
Assessment: The dependency updates follow semantic versioning conventions with minor and patch version bumps. No breaking changes are expected based on the version ranges. The changes should be safe to merge after standard testing procedures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 45e1972 deployed to: https://meister-task-pr-71.ci.next.deskprodemo.com URLs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies in the
package.jsonfile to their latest versions. These updates affect both runtime and development dependencies, ensuring the project uses the most recent features, bug fixes, and security patches.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@sentry/react,@tanstack/react-query,react-hook-form,react-router-dom,styled-components, and others to their latest versions.@swc/core,@swc/helpers,@types/lodash,@types/react,@types/styled-components,jest-environment-jsdom,ts-jest,typescript, andviteto newer versions. [1] [2]Summary by Sourcery
Update project dependencies to newer versions across runtime and development tooling.
Enhancements:
Build: