-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Deps #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade Deps #98
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps several runtime and dev dependency versions in package.json (and syncs pnpm-lock.yaml) to the latest minor/patch releases, without changing any application or test code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:31-40` </location>
<code_context>
+ "@sentry/react": "^9.47.1",
"@sentry/vite-plugin": "^3.6.1",
"@tanstack/react-query": "^4.42.0",
"@types/react-flatpickr": "^3.8.11",
"date-fns": "^3.6.0",
"flatpickr": "^4.6.13",
</code_context>
<issue_to_address>
**suggestion:** Avoid maintaining two different versions of `@types/react-flatpickr` in both dependencies and devDependencies.
`@types/react-flatpickr` is declared twice with different versions (`dependencies`: 3.8.11, `devDependencies`: 3.8.8). This duplication and mismatch can cause confusing resolution behavior. Please keep a single entry with one version (likely in `devDependencies` only, unless needed at runtime).
Suggested implementation:
```
"@tanstack/react-query": "^4.42.0",
"date-fns": "^3.6.0",
```
In `devDependencies`, ensure there is a single `@types/react-flatpickr` entry and align its version to the desired one (e.g. update `"@types/react-flatpickr": "^3.8.8"` to `"@types/react-flatpickr": "^3.8.11"` if that’s the version you want to standardize on).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit d9919f5 deployed to: https://jira-pr-98.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates multiple dependencies to their latest patch or minor versions, including both runtime and development dependencies. The changes follow semantic versioning conventions with no major version updates that would introduce breaking changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency version specifiers for 13 packages (8 runtime, 5 dev dependencies) |
| pnpm-lock.yaml | Reflects the resolved versions and transitive dependency updates from the package.json changes |
The dependency updates include:
- Runtime dependencies: @deskpro/app-sdk (6.0.7→6.0.8), @sentry/react (9.46.0→9.47.1), formik (2.4.8→2.4.9), lodash-es (4.17.21→4.17.22), react-hook-form (7.66.0→7.70.0), react-router-dom (6.30.1→6.30.2), styled-components (6.1.19→6.2.0)
- Dev dependencies: @swc/core (1.15.1→1.15.8), @swc/helpers (0.5.17→0.5.18), @types/react (18.3.26→18.3.27), @types/styled-components (5.1.35→5.1.36), ts-jest (29.4.5→29.4.6)
All updates are minor or patch version bumps that should not introduce breaking changes. The lockfile changes are consistent with the package.json updates and include expected transitive dependency updates.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies in the
package.jsonfile to their latest patch or minor versions. These updates include both runtime dependencies and development dependencies, aiming to keep the project up-to-date with bug fixes and improvements from upstream libraries.Dependency updates:
@deskpro/app-sdk,@sentry/react,formik,lodash-es,react-hook-form,react-router-dom, andstyled-componentsamong others. [1] [2]@swc/core,@swc/helpers,@types/react,@types/styled-components, andts-jest. [1] [2]Summary by Sourcery
Update project dependencies to newer patch and minor versions to keep runtime and tooling up to date.
Build:
Chores: