-
Notifications
You must be signed in to change notification settings - Fork 17
Form to Contribute Data #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Form to Contribute Data #1669
Conversation
fnets
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a couple of things that you'll want to add before exposing a form to unauthenticated users for security reasons.
client/modules/reconportal/src/ReconSidePanel/ContributeDataModal.tsx
Outdated
Show resolved
Hide resolved
client/modules/reconportal/src/ReconSidePanel/ContributeDataModal.tsx
Outdated
Show resolved
Hide resolved
fnets
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM! Some geospatial folks should review too, but great work.
nathanfranklin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
Left a comment on form library usage. Waiting to test locally until we resolve the reCAPTCHA dev issues being discussed in Slack. happy to review on code alone if needed.
client/modules/reconportal/src/ReconSidePanel/ContributeDataModal.tsx
Outdated
Show resolved
Hide resolved
Also add to SubmitFeedbackModal
…ise-recapcha task/WP-828-addon: Use Google reCAPTCHA Enterprise in ContributeDataModal and backend
|
|
||
| const { mutate } = useCreateFeedbackTicket( | ||
| 'RECON-PORTAL', | ||
| 'Data Contribution' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'Data Contribution' | |
| 'Data Contribution for DesignSafe Recon Portal' |
client/package.json
Outdated
| "antd": "^5.16.4", | ||
| "axios": "^1.6.3", | ||
| "dayjs": "^1.11.0", | ||
| "formik": "^2.4.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formik and yup can be dropped now that you refactord to antd form
Overview:
Modal added "Email us to Contribute your Data" under Recon Portal
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
Need to add security