Suggestion: Move to gradle and paper's userdev plugin #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR, however I'm currently only conferable using Maven and find it personally easier to use than gradle, with which I had my fair share of issues, when I tried it or it was used in other projects. Consider your PR therefore to be stuck in limbo until I find the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding 1.21.3 support to the plugin I had some issues with the project setup. Debugging the project and adding new modules could be more comfortable.
I tried to switch the build tool from Maven to Gradle and use the gradle userdev plugin to setup the nms mappings.
The changes are tested with spigot and paper with the versions 1.21.3 and 1.21.4.
I'm not sure if you want to switch to gradle. If not I would keep that fork.