fix(portagent): remove hardcoded wsUrl to fix Docker WebSocket connection #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Problem: Bun compiler inlined `process.env.NODE_ENV !== "production"` as `true` during build, causing wsUrl to always return `ws://localhost:5200/ws` even in production Docker environments. This broke WebSocket connections when accessing from external hosts. Solution: Remove wsUrl from server response entirely. Frontend now always uses `window.location.host` to construct WebSocket URL. This works for both: - Development: Vite proxy forwards /ws to backend - Production: Same origin, direct connection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wsUrlfrom/agentx/inforesponsewindow.location.hostto construct WebSocket URLProblem
Bun compiler inlined
process.env.NODE_ENV !== "production"astrueduring build, causingwsUrlto always returnws://localhost:5200/wseven in production Docker environments. This broke WebSocket connections when accessing from external hosts.Solution
Remove
wsUrlfrom server response entirely. This works for both:/wsto backendTest Plan
/agentx/infono longer returnswsUrlin Docker environment🤖 Generated with Claude Code