This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Open
Conversation
seanfinan
reviewed
Jun 21, 2023
Contributor
seanfinan
left a comment
seanfinan
left a comment
There was a problem hiding this comment.
We don't want to add the dictionary lookup. I know that you used it for the test, but our utilization of the dictionary database will be much simpler and won't require any of the dictionary code. It will just be a select call, e.g. select CUI from CUI_TERMS where TEXT like '%searchword%' Don't worry about -changing- this, just don't check it in. I don't want to leave the branch around, just in case ...
Contributor
|
We will need to add HSQLDB as a dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some code that will do a thesaurus lookup in the future. I don't think this breaks anything. The rest of the changes are formatting. I'm not sure if the ncit_plus_21aa files will live here permanently. We can always remove them later.