Fix email domain whitelist and f-string syntax errors #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domain whitelist fix:
- Empty COGNITO_WHITELIST_DOMAINS='' now blocks all domains
- Previously empty string allowed all (security issue)
- Added '*' as alternative to 'all' for allowing all domains
- Uses __BLOCK_ALL__ sentinel to distinguish from allow-all
F-string syntax fix:
- Fixed nested quote syntax error on lines 3224, 3228
- Removed redundant lstrip('/') calls (already stripped)
- Changed to double-quoted f-strings with escaped quotes
Behavior:
- Empty string '' = block all domains
- 'all' or '*' = allow all domains
- 'lsmc.bio,lsmc.com' = whitelist specific domains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a security issue in email domain whitelist handling and fixes pre-existing f-string syntax errors.
Domain Whitelist Fix (Security)
COGNITO_WHITELIST_DOMAINS=""was allowing all domains instead of blocking all__BLOCK_ALL__sentinel pattern*as alternative toallfor allowing all domainsF-string Syntax Fix
lstrip('/')calls (path already stripped earlier)Behavior
""(empty string)"all"or"*""lsmc.bio,lsmc.com"Testing
python3 -m py_compile main.py)Pull Request opened by Augment Code with guidance from the PR author