Skip to content

Conversation

@mdio
Copy link

@mdio mdio commented Nov 10, 2023

Several things happened here in order to support current PHP versions:

  • Upgrade PHPUnit to 9 + fix test signature and bcmath errors with passing strings like "two"
  • Replace utf8_decode with mb_convert_encoding (as it's deprecated in PHP 8.2)
  • I then removed the code that was running when ext-mbstring wasn't available as it's a requirement now anyway.

mdio added 4 commits November 10, 2023 09:39
utf8_decode is deprecated in PHP 8.2.
ext-mbstring is now a requirement.
Because ext-mbstring is required now anyway.
Radcliffe pushed a commit to Radcliffe/Text-Statistics that referenced this pull request Dec 18, 2023
pattonwebz added a commit to equalizedigital/textstatistics that referenced this pull request Apr 2, 2024
@mdio
Copy link
Author

mdio commented Dec 16, 2024

@DaveChild could you please take a look at this PR?
We have this running in production just fine for over a year now.

Let me know if there's anything I can do to improve the PR.

@JoshHighland
Copy link

@DaveChild Can we get a merge on this?

@linh-ngophuochoai
Copy link

@DaveChild would love to have this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants