Skip to content

DRY out conditional logging ifs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toddpress wants to merge 6 commits into
base: master
Choose a base branch
from
Open

DRY out conditional logging ifs #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9a54b4
add guarded alias for console.log
toddpress Nov 27, 2017
bc50655
change conditional logger name
toddpress Nov 27, 2017
d8a2297
replace if (this.DEBUG) console statements
toddpress Nov 27, 2017
b70de7e
re-re-name resulting logger fn
toddpress Nov 27, 2017
2da1a68
lol
toddpress Nov 27, 2017
8301ee5
LOL
toddpress Nov 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions lib/eventbrite/eventbrite_v3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var http = require('http'),
request = require('request'),
helpers = require('./helpers');
helpers = require('./helpers'),
logIfDebug = ()=>{};

/**
* eventbrite API wrapper for the API version 3. This object should not be
Expand All @@ -23,6 +24,8 @@ function eventbriteAPI_v3(options) {
this.DEBUG = options.DEBUG || false;
this.contentType = options.contentType || 'application/json';
this.userAgent = options.userAgent || 'node-eventbrite/' + this.version;

logIfDebug = helpers.loggerWhenTrue(this.DEBUG);
}

module.exports = eventbriteAPI_v3;
Expand Down Expand Up @@ -68,12 +71,10 @@ eventbriteAPI_v3.prototype.execute = function (verb, resource, method, available
finalParams[currentParam] = givenParams[currentParam];
}

if (this.DEBUG) {
console.log("uri", uri);
console.log("verb", verb);
console.log("headers", headers);
console.log("finalParams", finalParams);
}
logIfDebug("uri", uri);
logIfDebug("verb", verb);
logIfDebug("headers", headers);
logIfDebug("finalParams", finalParams);

// Build our request object
var requestObject = {
Expand All @@ -96,7 +97,7 @@ eventbriteAPI_v3.prototype.execute = function (verb, resource, method, available
request(requestObject, function (error, response, body) {
var parsedResponse;
if (error) {
if (this.DEBUG)console.log("error", error);
logIfDebug("error", error);
var err = new Error('Unable to connect to the eventbrite API endpoint.');
err.error_message = error;
err.code = "REQUEST_ERROR";
Expand All @@ -106,11 +107,11 @@ eventbriteAPI_v3.prototype.execute = function (verb, resource, method, available
try {
parsedResponse = JSON.parse(body);
if (parsedResponse.error){
if (this.DEBUG)console.log("error", parsedResponse.error, parsedResponse.error_description);
logIfDebug("error", parsedResponse.error, parsedResponse.error_description);
return callback(helpers.createEventbriteError(parsedResponse));
}
} catch (error) {
if (this.DEBUG)console.log("error", error);
logIfDebug("error", error);
return callback(new Error('Error parsing JSON answer from eventbrite API.'));
}

Expand Down
6 changes: 6 additions & 0 deletions lib/eventbrite/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,9 @@ exports.createEventbriteError = function (errorResponse) {

return error;
};

/**
* @param isTrue Boolean switch for returned logging function
* @returns Guarded alias of console.log
*/
exports.loggerWhenTrue = (isTrue) => (...statements) => isTrue ? console.log.apply(console, statements) : void 0;