Skip to content

Conversation

@sbtr1
Copy link

@sbtr1 sbtr1 commented Oct 4, 2018

No description provided.

Copy link
Collaborator

@whatevergeek whatevergeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sbtr1 ,
thanks for helping on this.
please find my review comments below:

I've run the tests and it works. However, please consider the following minor changes and let me know once you have them applied:
file: data_cleaning/clean_wpdx_sample_data.py

  • in the clean_col_count function, please update the documentation comment to point to the correct card. It currently points to: https://trello.com/c/HHzNs0hS/1-column-countryname
    file: data_cleaning/test_clean_wpdx_sample_data.py
  • in the test_clean_col_count function, please update the documentation comment to refer to "col_count". Currently, it says "country_name".
  • Apart from the negative case. e.g. assert clean_wpdx_sample_data.clean_col_count('123') == 123

Feel free to let me know if there's any clarification.
Thanks again for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants