feat!(data-pipeline): include reason for chunks dropped telemetry #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 71.30% 71.32% +0.02%
==========================================
Files 413 416 +3
Lines 66161 66970 +809
==========================================
+ Hits 47174 47768 +594
- Misses 18987 19202 +215
🚀 New features to boost your workflow:
|
bantonsson
reviewed
Jan 15, 2026
BenchmarksComparisonBenchmark execution time: 2026-01-16 19:23:16 Comparing candidate commit 25be86c in PR branch Found 4 performance improvements and 3 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. scenario:benching serializing traces from their internal representation to msgpack
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/x371413321323331
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
bantonsson
reviewed
Jan 16, 2026
Contributor
bantonsson
left a comment
bantonsson
left a comment
There was a problem hiding this comment.
The change looks good, but there are new lines missing test coverage. Also, how do we deal with semver? This is a breaking change API wise.
| if data.chunks_dropped > 0 { | ||
| let key = self.metrics.get(metrics::MetricKind::ChunksDropped); | ||
| if data.chunks_dropped_p0 > 0 { | ||
| let key = self.metrics.get(metrics::MetricKind::ChunksDroppedP0); |
Contributor
Author
There was a problem hiding this comment.
Good catch, added some more tests.
ekump
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we drop trace chunks due to a problem we emit telemetry, but we weren't including the reason tags. We also were not emitting chunks dropped telemetry for chunks dropped for valid sampling reasons. This PR addresses both issues. Now telemetry should have one of the following reasons tagged for
trace_chunks_dropped:p0_dropserialization_errorsend_failureMotivation
More accurate telemetry is good
Additional Notes
breaking change: The telemetry module in
libdd-data-pipelinewaspub. It should bepub(crate).How to test the change?
Existing tests have been updated.