-
Notifications
You must be signed in to change notification settings - Fork 12
Add tip of main branch check to preflight skill #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ## Execute All Checks | ||
|
|
||
| Run each check in order. **STOP on any failure and report the issue.** | ||
| Run all these checks as one BASH script to minimize the number of tool calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that if I just let it run every check individually that Claude was harassing me with "are you sure you want to run X" for every step and it was slowing down the whole process.
(This is for when I ran /lading:preflight directly)
464fa11 to
e1c1e7f
Compare
|
e1c1e7f to
a65047b
Compare
|
I tweaked the code so that it doesn't enforce main if you're not on main, latest run: Running |
|
Not totally sold on this yet. Going to move it back to draft. |

What does this PR do?
lading:preflight: remove the all-in-one script as it was duplicating what the steps were declaring but with less informationlading:preflight: tweaked the execute all checks to combine all of the checks into 1 bash invocation so that we don't get harassed with "are you sure you want to run X tool" over and over for every checklading:preflight: added an initial phase which checks that if you're starting on main, you're starting at the tip of mainlading:preflight: tweaked the report to specify the date time format of the timestamplading:preflight: added a small step at the end of the checks to print out the current date timeMotivation
I noticed that, when I ran the optimization loop in the background, it did not check to see if we were at the latest of main. We want this because we're storing the state of the optimizations in git and we want to be able to fetch the latest definition of the skills before doing anything.
Related issues
N/A
Additional Notes
Tested by invoking
lading:preflightin Claude and looking at the report.