Skip to content

Conversation

@preinlein
Copy link
Contributor

@preinlein preinlein commented Jan 15, 2026

What does this PR do?

  • lading:preflight: remove the all-in-one script as it was duplicating what the steps were declaring but with less information
  • lading:preflight: tweaked the execute all checks to combine all of the checks into 1 bash invocation so that we don't get harassed with "are you sure you want to run X tool" over and over for every check
  • lading:preflight: added an initial phase which checks that if you're starting on main, you're starting at the tip of main
  • lading:preflight: tweaked the report to specify the date time format of the timestamp
  • lading:preflight: added a small step at the end of the checks to print out the current date time

Motivation

I noticed that, when I ran the optimization loop in the background, it did not check to see if we were at the latest of main. We want this because we're storing the state of the optimizations in git and we want to be able to fetch the latest definition of the skills before doing anything.

Related issues

N/A

Additional Notes

Tested by invoking lading:preflight in Claude and looking at the report.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

## Execute All Checks

Run each check in order. **STOP on any failure and report the issue.**
Run all these checks as one BASH script to minimize the number of tool calls.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that if I just let it run every check individually that Claude was harassing me with "are you sure you want to run X" for every step and it was slowing down the whole process.

(This is for when I ran /lading:preflight directly)

@preinlein preinlein marked this pull request as ready for review January 15, 2026 20:00
@preinlein preinlein requested a review from a team as a code owner January 15, 2026 20:00
@preinlein preinlein marked this pull request as draft January 15, 2026 20:04
@preinlein preinlein force-pushed the paul.reinlein/add-main-branch-check-to-preflight branch from 464fa11 to e1c1e7f Compare January 15, 2026 20:17
@preinlein
Copy link
Contributor Author

$ claude
$ /lading:preflight
⏺ I'll run the lading preflight checklist to verify the environment is ready for optimization work.
Bash command 
... (this is the full bash command)
 Do you want to proceed?
 ❯ 1. Yes
   2. No
...
⏺ LADING PREFLIGHT REPORT
  =======================
  Timestamp: 2026-01-15 15:19:12
  Status: FAIL
  Legend: [*] present  [ ] missing (optional)  [X] failed

  Phase 1 - Main Branch Sync:
    [X] Not on main branch (currently on: paul.reinlein/add-main-branch-check-to-preflight)
        Fix: git checkout main

  Phase 2 - Rust Toolchain:
    [*] rustc 1.90.0
    [*] cargo 1.90.0
    [*] cargo-nextest 0.9.102

  Phase 3 - CI Scripts:
    [*] ci/validate
    [*] ci/test
    [*] ci/check
    [*] ci/clippy
    [*] ci/fmt
    [*] ci/kani

  Phase 4 - Build:
    [*] ci/check passes
    [*] payloadtool built

  Phase 5 - Benchmarking:
    [*] hyperfine 1.20.0
    [*] cargo-criterion 1.1.0
    [*] criterion benchmarks present

  Phase 6 - Profiling:
    [*] samply
    [*] sample(macOS)

  Phase 7 - Memory:
    [*] payloadtool --memory-stats
    [ ] heaptrack (optional)
    [*] valgrind

  Phase 8 - Git Config:
    [*] user.name configured
    [*] user.email configured

  Failed checks:
    [X] Not on main branch - currently on paul.reinlein/add-main-branch-check-to-preflight
        Fix: git checkout main

  DO NOT proceed with optimization skills until all required checks pass.

  The preflight check has FAILED because you're not on the main branch. You're currently on paul.reinlein/add-main-branch-check-to-preflight.

  To fix this, run:
  git checkout main

  Then re-run /lading:preflight to verify the environment is ready for optimization work.

  All other checks passed successfully - the environment is otherwise fully configured with all required tools.

@preinlein preinlein force-pushed the paul.reinlein/add-main-branch-check-to-preflight branch from e1c1e7f to a65047b Compare January 15, 2026 20:37
@preinlein preinlein changed the title Add main branch check to preflight skill Add tip of main branch check to preflight skill Jan 15, 2026
@preinlein
Copy link
Contributor Author

preinlein commented Jan 15, 2026

I tweaked the code so that it doesn't enforce main if you're not on main, latest run:

$ claude
$ /lading:preflight
⏺ I'll run the lading preflight checklist to verify the environment is ready for optimization work.
Bash command 
... (this is the full bash command)
 Do you want to proceed?
 ❯ 1. Yes
   2. No
...
⏺ LADING PREFLIGHT REPORT
  =======================
  Timestamp: 2026-01-15 15:39:04
  Status: PASS
  Legend: [*] present  [ ] missing (optional)  [X] failed

  Phase 1 - Main Branch Sync:
    [*] Not on main - check skipped (branch: paul.reinlein/add-main-branch-check-to-preflight)
    [*] Working tree: clean

  Phase 2 - Rust Toolchain:
    [*] rustc 1.90.0
    [*] cargo 1.90.0
    [*] cargo-nextest 0.9.102

  Phase 3 - CI Scripts:
    [*] ci/validate
    [*] ci/test
    [*] ci/check
    [*] ci/clippy
    [*] ci/fmt
    [*] ci/kani

  Phase 4 - Build:
    [*] ci/check passes
    [*] payloadtool built

  Phase 5 - Benchmarking:
    [*] hyperfine 1.20.0
    [*] cargo-criterion 1.1.0
    [*] criterion benchmarks present

  Phase 6 - Profiling:
    [*] samply
    [*] sample(macOS)

  Phase 7 - Memory:
    [*] payloadtool --memory-stats
    [ ] heaptrack (optional)
    [*] valgrind (optional)

  Phase 8 - Git Config:
    [*] user.name configured (Paul Reinlein)
    [*] user.email configured (paul.reinlein@datadoghq.com)

  Ready for: /lading:optimize:hunt, /lading:optimize:review, /lading:optimize:rescue

  Environment validated successfully. All required tools are present and the environment is ready for optimization work.

Running /lading:optimize:hunt afterwards proceeded "as normal" without any interruption.

@preinlein preinlein marked this pull request as ready for review January 15, 2026 20:41
@preinlein
Copy link
Contributor Author

Not totally sold on this yet. Going to move it back to draft.

@preinlein preinlein marked this pull request as draft January 16, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants