Extract observer into new crate #1713
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: scottopell <996472+scottopell@users.noreply.github.com>
…ption Make linux, cgroup, procfs modules and key functions public to allow external crates like fgm-observer to use the polling APIs directly without going through the Server interface. Public API changes: - linux module (lib.rs) - cgroup, procfs modules (linux.rs) - v2 module (cgroup.rs) - memory module (procfs.rs) - smaps_rollup module (procfs/memory.rs) - poll function (cgroup/v2.rs)
Make Aggregator struct, poll function, and Error enum public in smaps_rollup module to allow external crates to use memory sampling functionality.
- Add num_cpus to workspace dependencies for CPU count detection - Document all public modules, types, and functions to satisfy linter - Fix missing docs for linux, cgroup, procfs modules - Add comprehensive error variant documentation
This was referenced Jan 15, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?