Adds total_bytes_received metric emitted by all blackholes
#1702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds another
bytes_receivedmetric calledtotal_bytes_receivedemitted by every blackhole that is guaranteed to be a single series.Motivation
In current state if we were to configure lading to have multiple different types of blackholes we would emit multiple
bytes_receivedseries since the labels passed through to blackhole metrics havecomponent:blackholeandcomponent_name:{type of blackhole}.In addition, if you supply an ID when defining a blackhole, if there are multiple (even if they are the same type) we will similarly have multiple
bytes_receivedseriesFor clarity I find it appealing to have one
total_bytes_receivedmetric for all blackholes while maintaining the current behavior forbytes_receivedAdditional Notes
See this notebook for more context