Skip to content

Conversation

@cmetz100
Copy link
Contributor

What does this PR do?

Adds another bytes_received metric called total_bytes_received emitted by every blackhole that is guaranteed to be a single series.

Motivation

In current state if we were to configure lading to have multiple different types of blackholes we would emit multiple bytes_received series since the labels passed through to blackhole metrics have component:blackhole and component_name:{type of blackhole}.

In addition, if you supply an ID when defining a blackhole, if there are multiple (even if they are the same type) we will similarly have multiple bytes_received series

For clarity I find it appealing to have one total_bytes_received metric for all blackholes while maintaining the current behavior for bytes_received

Additional Notes

See this notebook for more context

Signed-off-by: Caleb Metz <caleb.metz@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants