Skip to content

Conversation

@joshuay03
Copy link

We're in the process of enabling Puma's preload_app! config at @buildkite. When auditing threads spawned during boot, Puma flagged this gem's sender thread as potentially not fork safe. However, based on the documentation for this gem and the implementation of Datadog::Statsd::Sender#add, the sender thread appears fork safe to me.

This PR adds a :fork_safe thread variable that Puma uses to exclude threads from its safety reporting, so that anyone else auditing their threads this way won't see false positives from this gem.

Refs:

@joshuay03 joshuay03 requested a review from a team as a code owner July 24, 2025 06:47
@joshuay03 joshuay03 moved this to In Progress / Pending Review in Open Source Jul 24, 2025
@joshuay03 joshuay03 force-pushed the mark-sender-thread-as-fork-safe branch from 2371e4a to c70dfad Compare July 24, 2025 07:36
@joshuay03 joshuay03 force-pushed the mark-sender-thread-as-fork-safe branch from c70dfad to f672101 Compare September 23, 2025 20:59
@joshuay03 joshuay03 requested a review from nightpool September 30, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants