Skip to content

EOL DEPENDENCY UPGRADE: major: github.com/sony/gobreaker · minor: github.com/stretchr/testify #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
campaigner-prod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EOL DEPENDENCY UPGRADE: major: github.com/sony/gobreaker · minor: github.com/stretchr/testify #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ require (
github.com/aws/aws-sdk-go-v2/service/kms v1.27.9
github.com/aws/aws-xray-sdk-go/v2 v2.0.0
github.com/cenkalti/backoff/v4 v4.2.1
github.com/sony/gobreaker v0.5.0
github.com/stretchr/testify v1.10.0
github.com/sony/gobreaker/v2 v2.4.0
github.com/stretchr/testify v1.11.1
go.opentelemetry.io/otel v1.35.0
gopkg.in/DataDog/dd-trace-go.v1 v1.74.6
)
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ github.com/secure-systems-lab/go-securesystemslib v0.9.0/go.mod h1:DVHKMcZ+V4/wo
github.com/shirou/gopsutil/v4 v4.25.3 h1:SeA68lsu8gLggyMbmCn8cmp97V1TI9ld9sVzAUcKcKE=
github.com/shirou/gopsutil/v4 v4.25.3/go.mod h1:xbuxyoZj+UsgnZrENu3lQivsngRR5BdjbJwf2fv4szA=
github.com/sirupsen/logrus v1.7.0/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
github.com/sony/gobreaker v0.5.0 h1:dRCvqm0P490vZPmy7ppEk2qCnCieBooFJ+YoXGYB+yg=
github.com/sony/gobreaker v0.5.0/go.mod h1:ZKptC7FHNvhBz7dN2LGjPVBz2sZJmc0/PkyDJOjmxWY=
github.com/sony/gobreaker/v2 v2.4.0 h1:g2KJRW1Ubty3+ZOcSEUN7K+REQJdN6yo6XvaML+jptg=
github.com/sony/gobreaker/v2 v2.4.0/go.mod h1:pTyFJgcZ3h2tdQVLZZruK2C0eoFL1fb/G83wK1ZQl+s=
github.com/spaolacci/murmur3 v1.1.0 h1:7c1g84S4BPRrfL5Xrdp6fOJ206sU9y293DDHaoy0bLI=
github.com/spaolacci/murmur3 v1.1.0/go.mod h1:JwIasOWyU6f++ZhiEuf87xNszmSA2myDM2Kzu9HwQUA=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
Expand All @@ -191,8 +191,8 @@ github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
github.com/tinylib/msgp v1.2.5 h1:WeQg1whrXRFiZusidTQqzETkRpGjFjcIhW6uqWH09po=
github.com/tinylib/msgp v1.2.5/go.mod h1:ykjzy2wzgrlvpDCRc4LA8UXy6D8bzMSuAF3WD57Gok0=
github.com/tklauser/go-sysconf v0.3.15 h1:VE89k0criAymJ/Os65CSn1IXaol+1wrsFHEB8Ol49K4=
Expand Down
2 changes: 1 addition & 1 deletion internal/metrics/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

"github.com/DataDog/datadog-lambda-go/internal/logger"
"github.com/cenkalti/backoff/v4"
"github.com/sony/gobreaker"
"github.com/sony/gobreaker/v2"
)

type (
Expand All @@ -42,7 +42,7 @@
batcher *Batcher
shouldRetryOnFail bool
isProcessing bool
breaker *gobreaker.CircuitBreaker

Check failure on line 45 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 45 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 45 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / unit-test 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 45 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / unit-test 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 45 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 45 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation
}
)

Expand All @@ -66,7 +66,7 @@
}
}

func MakeCircuitBreaker(circuitBreakerInterval time.Duration, circuitBreakerTimeout time.Duration, circuitBreakerTotalFailures uint32) *gobreaker.CircuitBreaker {

Check failure on line 69 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 69 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 69 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / unit-test 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 69 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / unit-test 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 69 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation

Check failure on line 69 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use generic type gobreaker.CircuitBreaker[T any] without instantiation
readyToTrip := func(counts gobreaker.Counts) bool {
return counts.TotalFailures > circuitBreakerTotalFailures
}
Expand All @@ -77,7 +77,7 @@
Timeout: circuitBreakerTimeout,
ReadyToTrip: readyToTrip,
}
return gobreaker.NewCircuitBreaker(st)

Check failure on line 80 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

in call to gobreaker.NewCircuitBreaker, cannot infer T (declared at ../../../go/pkg/mod/github.com/sony/gobreaker/v2@v2.4.0/gobreaker.go:116:24) (typecheck)

Check failure on line 80 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

in call to gobreaker.NewCircuitBreaker, cannot infer T (declared at ../../../go/pkg/mod/github.com/sony/gobreaker/v2@v2.4.0/gobreaker.go:116:24)) (typecheck)

Check failure on line 80 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / unit-test 

in call to gobreaker.NewCircuitBreaker, cannot infer T (declared at ../../../go/pkg/mod/github.com/sony/gobreaker/v2@v2.4.0/gobreaker.go:116:24)

Check failure on line 80 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / unit-test 

in call to gobreaker.NewCircuitBreaker, cannot infer T (declared at ../../../go/pkg/mod/github.com/sony/gobreaker/v2@v2.4.0/gobreaker.go:116:24)

Check failure on line 80 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

in call to gobreaker.NewCircuitBreaker, cannot infer T (declared at ../../../go/pkg/mod/github.com/sony/gobreaker/v2@v2.4.0/gobreaker.go:116:24) (typecheck)

Check failure on line 80 in internal/metrics/processor.go

View workflow job for this annotation

GitHub Actions / lint 

in call to gobreaker.NewCircuitBreaker, cannot infer T (declared at ../../../go/pkg/mod/github.com/sony/gobreaker/v2@v2.4.0/gobreaker.go:116:24)) (typecheck)
}

func (p *processor) AddMetric(metric Metric) {
Expand Down
Loading