Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 80.55% 80.43% -0.12%
==========================================
Files 13 13
Lines 905 910 +5
==========================================
+ Hits 729 732 +3
- Misses 145 146 +1
- Partials 31 32 +1 ☔ View full report in Codecov by Sentry. |
| if r := recover(); r != nil { | ||
| response = nil | ||
| errResponse = fmt.Errorf("Panic: %v", r) | ||
| } |
Contributor
There was a problem hiding this comment.
I'm concerned that since we do not re-panic, we're actually changing how a panicking function functions.
Contributor
Author
There was a problem hiding this comment.
tbh, I have the very same concern.
I think the alternative would be to re-panic after we send the trace.
defer func() {
if r := recover(); r != nil {
// send the trace somehow
panic(r)
}
}()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Fix #165
Testing Guidelines
Added unittest.

Also manually tested:
Additional Notes
Types of changes
Checklist