Skip to content

Conversation

@BenoitZugmeyer
Copy link
Member

Also make it simpler, as we only care about ids

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 18, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.34 KiB 164.46 KiB +123 B +0.07%
Rum Profiler 4.33 KiB 4.48 KiB +160 B +3.61%
Rum Recorder 20.03 KiB 20.03 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.63 KiB 121.35 KiB -280 B -0.22%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance

Pending...

🔗 RealWorld

@datadog-official
Copy link

datadog-official bot commented Dec 18, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 2 Tests failed

cookie getCurrentSite caches the result from Safari 12.1.2 (Mac OS 10.14.6) (Datadog) (Fix with Cursor)
Expected spy cookie to have been called 2 times. It was called 0 times.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:50:43 <- /tmp/_karma_webpack_270849/commons.js:48710:49
<Jasmine>
cookie getCurrentSite returns the eTLD+1 for foo.bar.baz.example.com from Safari 12.1.2 (Mac OS 10.14.6) (Datadog) (Fix with Cursor)
Expected 'foo.bar.baz.example.com' to be 'example.com'.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:24:61 <- /tmp/_karma_webpack_270849/commons.js:48690:108
<Jasmine>

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
Patch Coverage: 92.86%
Overall Coverage: 77.22% (-0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cd45062 | Docs | Datadog PR Page | Was this helpful? Give us feedback!


lifeCycle.subscribe(LifeCycleEventType.RAW_RUM_EVENT_COLLECTED, ({ rawRumEvent, startTime, duration }) => {
if (rawRumEvent.type === 'long_task') {
history.add(rawRumEvent.long_task.id, startTime).close(addDuration(startTime, duration!))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 warning: ‏We also send startClock, duration and entryType in the Profiling track.

Also make it simpler, as we only care about ids
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/move-long-task-context branch from 794e9b1 to cd45062 Compare December 19, 2025 16:35
Base automatically changed from aymeric/fix-long-task-association to main January 5, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants