Skip to content

Conversation

@BenoitZugmeyer
Copy link
Member

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@datadog-official
Copy link

datadog-official bot commented Dec 18, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 323 Tests failed

browser extensions › should not warn - edge case simulating NextJs with an extension that override `appendChild` from browser-extensions/browserExtensions.scenario.ts (Datadog) (Fix with Cursor)

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 1

       at browser-extensions/browserExtensions.scenario.ts:114

      112 |       expect(intakeRegistry.rumViewEvents).toHaveLength(1)
      113 |
...
logs entry should add a `_setDebug` that works from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog) (Fix with Cursor)
Error: Expected spy error to have been called once. It was called 2 times.
    at <Jasmine>
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/logs/src/boot/logsPublicApi.spec.ts:52:24 <- /tmp/_karma_webpack_622399/commons.js:155639:28)
    at <Jasmine>
user, account and global context › should be included in all rum events › async from context.scenario.ts (Datadog) (Fix with Cursor)
createTest.ts:244:3 async

[chromium] › ../lib/framework/createTest.ts:244:3 › user, account and global context › should be included in all rum events › async 

    Error: expect(received).toHaveLength(expected)

    Expected length: 0
    Received length: 1
    Received array:  [{"level": "error", "message": "Datadog Browser SDK: Recorder failed to start: an error occurred while initializing the module: TypeError: Failed to resolve module specifier './chunks/recorder-5beded716eb5a95f9087.js'. The base URL is about:blank because import() is called from a CORS-cross-origin script.
        at i.f.j (http://172.18.74.45:9386/datadog-rum.js:1:54280)
...
View all

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 78.04% (+0.80%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ac6f0cf | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 18, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.34 KiB 165.75 KiB +1.42 KiB +0.86%
Undefined Undefined N/A 20.22 KiB N/A N/A N/A
Logs 56.14 KiB 56.18 KiB +41 B +0.07%
Flagging 944 B 989 B +45 B +4.77%
Rum Slim 121.62 KiB 121.67 KiB +45 B +0.04%
Worker 23.63 KiB 23.66 KiB +35 B +0.14%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.004 0.0055 +37.50%
RUM - add action 0.0161 0.0172 +6.83%
RUM - add error 0.0148 0.0151 +2.03%
RUM - add timing 0.0027 0.0041 +51.85%
RUM - start view 0.0032 0.0049 +53.12%
RUM - start/stop session replay recording 0.0008 0.0008 0.00%
Logs - log message 0.0133 0.0191 +43.61%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.54 KiB 26.64 KiB +1.10 KiB
RUM - add action 52.59 KiB 51.79 KiB -819 B
RUM - add timing 24.36 KiB 24.34 KiB -19 B
RUM - add error 55.00 KiB 55.05 KiB +53 B
RUM - start/stop session replay recording 23.56 KiB 24.24 KiB +696 B
RUM - start view 422.92 KiB 423.98 KiB +1.07 KiB
Logs - log message 44.35 KiB 44.30 KiB -50 B

🔗 RealWorld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants