-
Notifications
You must be signed in to change notification settings - Fork 166
[Extension] Handle function values in configuration #4042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Extension] Handle function values in configuration #4042
Conversation
| parentValue: descriptor.value as unknown[], | ||
| value: child, | ||
| path: descriptor.path, | ||
| path: descriptor.path ? `${descriptor.path}.${i}` : String(i), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: The omission of the index was intentional. It follows the events platform query, so you can copy a path and paste it in the Datadog ui.
| defaultCollapseLevel: number | ||
| getMenuItemsForPath?: GetMenuItemsForPath | ||
| formatValue: FormatValue | ||
| sdkType?: 'rum' | 'logs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: it could be nice to keep the json component more or less generic, because it's used in multiple places, not only for displaying configuration. Maybe add a onRevealFunctionLocation prop and externalize that logic?
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
BeltranBulbarellaDD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
When inspecting the RUM/Logs configuration using the Browser SDK extension, functions are shown as

{empty object}.This can mislead users to think that it's undefined / not present.
Changes
Test instructions
Checklist