Skip to content

Conversation

@thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Dec 17, 2025

Motivation

We want to avoid hardcoding the list of datacenter in the release process. This will remove the need for creating a PR for new DCs.

For this we discover the list of DC and their corresponding site using ddtool Runtime Metadata Service.

PR stacked on top of #3973

Changes

  • Refactor a bit to normalize usage of datacenter vs uploadPath and try to make things more clear
  • Added unit tests for deploy-prod-dc script.
  • removed siteByDatacenter in favor of a ddtool command

Todos

  • install ddtool on the CI (or find another way) used Runtime Metadata Service
  • fix upload-source-maps test failing. for some reason the mock seems to initialize too late

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@datadog-official
Copy link

datadog-official bot commented Dec 17, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 77.24% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f710785 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/better-release-monitor-check branch from 9e7570b to 247005e Compare December 17, 2025 09:50
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/no-hardcoded-list-of-dc branch 3 times, most recently from 8611867 to 3517742 Compare December 18, 2025 15:28
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 18, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.34 KiB 164.34 KiB 0 B 0.00%
Rum Profiler 4.32 KiB 4.32 KiB 0 B 0.00%
Rum Recorder 20.03 KiB 20.03 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.62 KiB 121.62 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0064 0.0047 -26.56%
RUM - add action 0.017 0.0117 -31.18%
RUM - add error 0.0157 0.012 -23.57%
RUM - add timing 0.003 0.0026 -13.33%
RUM - start view 0.0046 0.0035 -23.91%
RUM - start/stop session replay recording 0.0008 0.0007 -12.50%
Logs - log message 0.0144 0.0135 -6.25%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.23 KiB 25.25 KiB -995 B
RUM - add action 48.74 KiB 47.47 KiB -1.27 KiB
RUM - add timing 24.47 KiB 24.29 KiB -186 B
RUM - add error 54.83 KiB 53.86 KiB -997 B
RUM - start/stop session replay recording 23.65 KiB 23.39 KiB -266 B
RUM - start view 423.65 KiB 422.12 KiB -1.53 KiB
Logs - log message 43.38 KiB 45.45 KiB +2.07 KiB

🔗 RealWorld

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/better-release-monitor-check branch from f018b53 to 931ed9e Compare December 19, 2025 09:47
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/no-hardcoded-list-of-dc branch from 0dfbe94 to 1f23c10 Compare December 22, 2025 08:30
…tching

Replace the ddtool command-line tool with direct fetch calls to the
runtime-metadata-service API. This enables the scripts to work in CI
environments where ddtool is not available.

Key changes:
- Refactored datacenter.ts to use fetchHandlingError with Vault token
  authentication instead of ddtool command
- Made all datacenter functions async with lazy initialization
- Added comprehensive test coverage for datacenter module
@thomas-lebeau thomas-lebeau marked this pull request as ready for review January 7, 2026 12:48
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner January 7, 2026 12:48
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38ec673ee6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +18 to +20
export async function getAllMinorDcs(): Promise<string[]> {
return (await getAllDatacenters()).filter((dc) => !MAJOR_DCS.includes(dc) && !dc.startsWith('pr'))
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep private regions in the deploy pipeline

Filtering getAllMinorDcs() to exclude pr* means the minor-dcs group no longer includes private regions, but both deploy pipelines still only invoke deploy-prod-dc.ts with DATACENTER: minor-dcs and don’t add a private-regions step. As a result, private regions like prtest00/prtest01 won’t receive deployments anymore unless a new pipeline step is added or they’re re‑included here.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants