-
Notifications
You must be signed in to change notification settings - Fork 166
👷 do not rely on hardcoded list of DCs #4037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: thomas.lebeau/better-release-monitor-check
Are you sure you want to change the base?
👷 do not rely on hardcoded list of DCs #4037
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: f710785 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
9e7570b to
247005e
Compare
8611867 to
3517742
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
f018b53 to
931ed9e
Compare
0dfbe94 to
1f23c10
Compare
…tching Replace the ddtool command-line tool with direct fetch calls to the runtime-metadata-service API. This enables the scripts to work in CI environments where ddtool is not available. Key changes: - Refactored datacenter.ts to use fetchHandlingError with Vault token authentication instead of ddtool command - Made all datacenter functions async with lazy initialization - Added comprehensive test coverage for datacenter module
… datacenter deployments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38ec673ee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export async function getAllMinorDcs(): Promise<string[]> { | ||
| return (await getAllDatacenters()).filter((dc) => !MAJOR_DCS.includes(dc) && !dc.startsWith('pr')) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep private regions in the deploy pipeline
Filtering getAllMinorDcs() to exclude pr* means the minor-dcs group no longer includes private regions, but both deploy pipelines still only invoke deploy-prod-dc.ts with DATACENTER: minor-dcs and don’t add a private-regions step. As a result, private regions like prtest00/prtest01 won’t receive deployments anymore unless a new pipeline step is added or they’re re‑included here.
Useful? React with 👍 / 👎.
Motivation
We want to avoid hardcoding the list of datacenter in the release process. This will remove the need for creating a PR for new DCs.
For this we discover the list of DC and their corresponding site using
Runtime Metadata Service.ddtoolPR stacked on top of #3973
Changes
datacentervsuploadPathand try to make things more clearsiteByDatacenterin favor of a ddtool commandTodos
install ddtool on the CI (or find another way)used Runtime Metadata ServiceTest instructions
Checklist