-
Notifications
You must be signed in to change notification settings - Fork 166
Make the Dev Ext capable of Injecting CDN SDK #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make the Dev Ext capable of Injecting CDN SDK #4026
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
To use Codex here, create a Codex account and connect to github. |
|
@codex please review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex pls review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: b08c7a9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
@codex pls review |
| sdkCode = sdkCode.replace( | ||
| /__webpack_require__\.p\s*=\s*[^;]+;/g, | ||
| `__webpack_require__.p = ${JSON.stringify(baseUrl)};` | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because the SDK tried to load the recorder from the wrong place. So when we inject and then override need to adjust the recorder URL.
Open to suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
The idea is to be able to inject the SDK on a page that does not have it. Injecting the local version and CDN version.
Changes
Added new button: Inject Prod CDN.
Remove old override, now redirect does what override did.
Test instructions
Build the dev extension and while running the local SDK do
yarn devon the dev extension folder. There in the initial page override using redirect. Go to any page without the SDK and inject the CDN ProdScreen.Recording.2025-12-11.at.15.41.37.mov
Checklist