Assorted DARKPACK TODOs and code cleanup #600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Would atomize into diff prs but Im doing all of this on my laptop rn.
just a whole lotta random bullshit, bulk of it was ensuring BP is only interacted with via adjust_bloodpool
and alot of the rest was item interaction cleanup. item interactions being in attack procs will mess with melberts eventual swing combat pr he had planned (which i still hope for)
Why It's Good For The Game
should fix #401
Changelog
🆑
qol: first key checked on a door has no delay
fix: abyss tentacles should be able to acctually make a sound as intended
fix: fixed tranforming BP dupe
fix: typhon brew is craftable
fix: humanity 10 vamps wont burn in the sun
image: blood hunt skull uses its onfloor
code: more non-combat item interactions are no longer in attack-by
code: all changes in BP should update your hud
/:cl: