Alt Job Titles #596
Open
Alt Job Titles #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FalloutFalcon
requested changes
Jan 27, 2026
Member
FalloutFalcon
left a comment
FalloutFalcon
left a comment
There was a problem hiding this comment.
Luckily most everything i have to say its just nits over modularity. All of the code seems good.
modular_darkpack/modules/alternative_job_titles/code/alt_job_titles.dm
Outdated
Show resolved
Hide resolved
modular_darkpack/modules/alternative_job_titles/code/alt_job_titles.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
…into alttitles
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
FalloutFalcon
approved these changes
Jan 29, 2026
modular_darkpack/master_files/code/modules/client/preferences_savefile.dm
Outdated
Show resolved
Hide resolved
modular_darkpack/master_files/code/modules/client/preferences_savefile.dm
Outdated
Show resolved
Hide resolved
Member
|
you should batch all of these commits. |
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
…into alttitles
Member
FalloutFalcon
left a comment
FalloutFalcon
left a comment
There was a problem hiding this comment.
oh i forgot to check the js mb.
tgui/packages/tgui/interfaces/PreferencesMenu/CharacterPreferences/JobsPage.tsx
Outdated
Show resolved
Hide resolved
tgui/packages/tgui/interfaces/PreferencesMenu/CharacterPreferences/JobsPage.tsx
Outdated
Show resolved
Hide resolved
tgui/packages/tgui/interfaces/PreferencesMenu/CharacterPreferences/JobsPage.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
IT WORKS THANK YOU DOPPLER AND MELBERT
Why It's Good For The Game
Changelog
🆑
add: Alt Job Titles
qol: Something about "records are unassigned by default, but if edited without input becomes unknown" I copy and pasted this shit man.
/:cl: