Ports First Teams from TFN #514
Conversation
Ports over all the stuff, testing to come
Its Cool
…nto FIRST-Team
Something's really fucked up with the unit tests, however that's an issue for later
Forgot the proper firing pin
…nto FIRST-Team
|
Make sure to use the |
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
…nto FIRST-Team
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
|
|
||
| //------------SHOES------------ | ||
| /obj/item/clothing/shoes/response | ||
| /obj/item/clothing/shoes/darkpack |
There was a problem hiding this comment.
/obj/item/clothing/shoes/darkpack is a misleading type path, as it would suggest its the default type path for all darkpack shoes but your using it for specifically ert and the icon files it defines force that.
are you looking for /obj/item/clothing/shoes/darkpack/response? /obj/item/clothing/shoes/darkpack does not acctually have any unique behavior nor is defined but i could see it for future proofing if that's what you were trying to do.
ditto for all the clothing here.
There was a problem hiding this comment.
It's just organizational/futureproofing, they were originally under the /response subtype before being changed to the /darkpack subtype after an earlier review by Chaz
There was a problem hiding this comment.
its gonna need to be /obj/item/clothing/shoes/darkpack/response, like i said, having it only be /darkpack yet all of its behavior and default vars being ert is really confusing.
| icon_state = "ftboots" | ||
| inhand_icon_state = null | ||
| gender = PLURAL | ||
| onflooricon = 'modular_darkpack/modules/ert/icons/onfloor.dmi' |
There was a problem hiding this comment.
define that makes them show up in mapping tools as onfloors. Find and replace the rest of them as well.
| onflooricon = 'modular_darkpack/modules/ert/icons/onfloor.dmi' | |
| ONFLOOR_ICON_HELPER('modular_darkpack/modules/ert/icons/onfloor.dmi') |
There was a problem hiding this comment.
You still need to fix the other instances.
|
|
||
|
|
||
| /obj/item/clothing/gloves/darkpack/firstteam | ||
| name = "First Team gloves" |
There was a problem hiding this comment.
capitalizing the First will cause it to be treated as a proper noun. likely not desired behavior. ditto for rest of gear.
| name = "First Team gloves" | |
| name = "\improper First Team gloves" |
There was a problem hiding this comment.
ditto for the rest of the gear.
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
…nto FIRST-Team
4 participants
Ports over all the stuff, testing to come
About The Pull Request
I'll fill this out once i've finished testing & tweaking everything,
Todo:
Finish the shittier Budget First Team so admins have an option that's not entirely wiping everyone out
Why It's Good For The Game
More admin toys are fun
Changelog
🆑
add: Pentex FIRST Team ERT
/:cl: