-
Notifications
You must be signed in to change notification settings - Fork 0
Create snyk-security.yml #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's Guide by SourceryThis pull request introduces a new GitHub Actions workflow file, No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying uniswap with
|
| Latest commit: |
3164077
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c6e97e0.uniswap-omj.pages.dev |
| Branch Preview URL: | https://dargon789-patch-snyk.uniswap-omj.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dargon789 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using specific Snyk action versions instead of relying on the default to avoid unexpected changes.
- The workflow is missing a trigger for pull requests targeting other branches than main.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add a new CI workflow to run Snyk security scans on push and pull requests to the main branch. The workflow runs Snyk Open Source, Snyk Code, Snyk Container and Snyk Infrastructure as Code, and uploads the Snyk Code results to GitHub Security Code Scanning.
CI: