Skip to content

CAS-696: fix saving temp data on voting options step #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
germanurrus wants to merge 1 commit into
base: release-v1.6.0
Choose a base branch
from
Open

CAS-696: fix saving temp data on voting options step #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions frontend/packages/client/src/components/ProposalCreate/StepTwo/StepTwo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import { useCommunityDetails } from 'hooks';
import { kebabToString } from 'utils';
import { Heading } from '@chakra-ui/react';
import { yupResolver } from '@hookform/resolvers/yup';
import identity from 'lodash/identity';
import pick from 'lodash/pick';
import pickBy from 'lodash/pickBy';
import { stepTwo } from '../FormConfig';
import VotingSelector from './VotingSelector';

Expand Down Expand Up @@ -71,24 +73,24 @@ const StepTwo = ({
moveToNextStep();
};

const defaultValueStrategy = useWatch({ control, name: 'strategy' });
const voteType = useWatch({ control, name: 'voteType' });
// watching all fields
const fields = useWatch({ control });
const {
strategy: defaultValueStrategy,
voteType,
choices: choicesTemp,
tabOption,
maxWeight,
minBalance,
} = fields;

// save vote type
useEffect(() => {
onDataChange({ voteType });
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [voteType]);
// **************************************************************
// This is to enable having choices when entering in preview mode
// fields are saved and validated when user hits on next
// by doing this we are saving the options before without validation
// when user hits next fields will be validated and overwritten with valid values
// for example it's possible to enter in preview mode with duplicated voting options
// but next will let the user know this needs to be updated
const choicesTemp = useWatch({ control, name: 'choices' });
const tabOption = useWatch({ control, name: 'tabOption' });

useEffect(() => {
let choices = choicesTemp;
if (tabOption === 'visual') {
Expand All @@ -102,6 +104,17 @@ const StepTwo = ({
}, [choicesTemp, tabOption]);
// **************************************************************

// saving temp updates on fields
useEffect(() => {
// removes undefined values
const data = pickBy(
{ voteType, strategy: defaultValueStrategy, maxWeight, minBalance },
identity
);
onDataChange(data);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [voteType, defaultValueStrategy, maxWeight, minBalance]);

const { isSubmitting, isValid, errors, isDirty } = formState;

useEffect(() => {
Expand Down