WinHttp.WinHttpRequest.5.1 usage #512

mlipok · 2024-02-27T10:58:03Z

Pull request

Proposed changes

Today I hit a problem when trying to update geckodriver where InetRead() returns with error

Checklist

I have read and noticed the CODE OF CONDUCT document
I have read and noticed the CONTRIBUTING document
I have added necessary documentation or screenshots (if appropriate)

Types of changes

Bugfix (change which fixes an issue)
Feature (change which adds functionality)
Code style update (formatting, renaming)
Refactoring (functional, structural)
Documentation content changes
Other (please describe)

What is the current behavior?

Sometimes InetRead and InetGet can return error thus there is no way to update driver with this udf.

What is the new behavior?

when InetRead returns error then WinHttp.WinHttpRequest.5.1 is used.

Influences and relationship to other functionality

none

Additional context

https://www.autoitscript.com/forum/topic/209621-inetget-alernative/
https://www.autoitscript.com/forum/topic/209610-inetget-dont-download-some-pages-since-ie11-is-no-longer-supported-by-some-sites
https://www.autoitscript.com/forum/topic/209472-download-problem-with-inetget/

System under test

FireFox

sven-seyfert · 2024-02-27T18:10:10Z

Hi @mlipok , since you use the same code block ...

If @error Then
	Local $oHTTP = ObjCreate("WinHttp.WinHttpRequest.5.1")
	$oHTTP.Open("GET", $sURL, False)
	$oHTTP.SetRequestHeader("User-Agent", "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0")
	$oHTTP.Send("")
	$sName = $oHTTP.ResponseBody
EndIf

... three times (for $sResult, $sData and $sDriverLatest), it would maybe be a good improvement to extract this code into a separate "internal usage" function 😀 .

Best regards
Sven

mlipok · 2024-02-28T20:15:21Z

I expected such request.
Will do it ASAP.

sven-seyfert · 2024-02-28T21:36:20Z

No pressure @mlipok , thanks for your stable contribution actions on this project 👌 .

mlipok · 2024-02-29T10:22:37Z

Done: added _WD_DownloadAsBinary

sven-seyfert · 2024-02-29T10:58:23Z

Cool, thanks @mlipok . I try to test it in the next day(s). Because I believe, the @error marcro could be a problem - but it's only a wild guess and feeling, no real statement. Let me test it 🤝 .

wd_helper.au3

sven-seyfert · 2024-02-29T20:46:57Z

wd_helper.au3

+; #FUNCTION# ====================================================================================================================
+; Name ..........: _WD_DownloadAsBinary


I think the function header should be ; #INTERNAL_USE_ONLY# ====== and the function should be __WD_DownloadAsBinary instead of _WD_DownloadAsBinary. Actually it does not matter, but it would fulfill the consistency 😇 .

If you have any reason to change _WD_DownloadAsBinary into internal usage only then you should try to apply the same reason to _WD_DownloadFile and see if this reason also makes sense here.

If you say that _WD_DownloadFile save data to file I would say that the destination does not matter here as I always try to avoid writing data to files on disk. Instead, I process the data in memory and write to database.

This is because of security reason (i.e. GDPR law) - I simply try to minimize the number of places where data leaves a trace (files on disc).

Summary: if any user of this UDF needs to use the function for download and writing data to a file, then the function of writing data to memory without writing it to disk is equally necessary.

Understood and fair enough @mlipok 👍 .

Then at least the README.md file also has to be adjusted, right?
I mean the additional function should be described in the README like the other functions too.
Is this usually made by @Danp2 ? I believe he do a "Prep release" commit which will contain such things, right? Or do we as PR authors also adjust these files 🤔 ?

Best regards
Sven

Is this usually made by @Danp2 ? I believe he do a "Prep release" commit which will contain such things, right? Or do we as PR authors also adjust these files 🤔 ?

@Danp2
What you think about ?

@Danp2 can you look here ?

Danp2

I haven't yet read through the past discussions on this PR, but I do have a few questions to add --

Do we need to support both InetRead and WinHttp downloads?
Is there functionality from WinHttp.au3 that could be used here instead of WinHttp.WinHttpRequest.5.1?

sven-seyfert · 2024-03-02T17:01:01Z

Is there functionality from WinHttp.au3 that could be used here instead of WinHttp.WinHttpRequest.5.1?

This is actually a really good question @Danp2. Interesting.

mlipok · 2024-03-02T18:03:55Z

Do we need to support both InetRead and WinHttp downloads?

Do not know.

mlipok · 2024-03-02T18:04:49Z

Is there functionality from WinHttp.au3 that could be used here instead of WinHttp.WinHttpRequest.5.1?

I think yes.
But I'm not familiar with winhttp.au3 udf.

mlipok · 2024-03-03T19:51:06Z

Do we need to support both InetRead and WinHttp downloads?

Do you mean to stop using InetRead in favor of WinHTTP functions ?

mlipok · 2024-03-03T19:56:01Z

Is there functionality from WinHttp.au3 that could be used here instead of WinHttp.WinHttpRequest.5.1?

I think yes. But I'm not familiar with winhttp.au3 udf.

maybe from here:
https://www.autoitscript.com/forum/topic/199088-download-a-zip-file-using-winhttp/?do=findComment&comment=1428601
https://www.autoitscript.com/forum/topic/174063-winhttp-download-an-exe-file/?do=findComment&comment=1259515

also some of my old attempts:
https://www.autoitscript.com/forum/topic/206771-winhttpau3-download-problem-youre-speaking-plain-http-to-an-ssl-enabled-server-port/?do=findComment&comment=1490309

Danp2

Do you mean to stop using InetRead in favor of WinHTTP functions ?

Yes, that is what I was wanting you to consider.

sven-seyfert · 2025-07-28T18:59:05Z

Few thoughts of mine:

After all these months, I lost the track of this PR. I lost the need or use case to switch from InetRead to a WinHTTP.au3 function. I also didn't read in the forums newer requests regarding this topic. I saw your mentioned links @mlipok, but no newer questions.

That's why I think about to leave it as it is at the moment.
But sure, this is only my thoughts - in general - no need, no action.

What do you folks think @Danp2 and @mlipok?

Best regards
Sven

WinHttp.WinHttpRequest.5.1 usage

e677835

added _WD_DownloadAsBinary

eb801b0

sven-seyfert reviewed Feb 29, 2024

View reviewed changes

wd_helper.au3 Outdated Show resolved Hide resolved

sven-seyfert reviewed Feb 29, 2024

View reviewed changes

wd_helper.au3 Outdated Show resolved Hide resolved

sven-seyfert reviewed Feb 29, 2024

View reviewed changes

wd_helper.au3 Show resolved Hide resolved

fix

de8a3e8

sven-seyfert reviewed Feb 29, 2024

View reviewed changes

error handling

8c54a77

This was referenced Mar 1, 2024

__WD_ErrHnd added notification to __WD_Error mlipok/au3WebDriver#3

Closed

__WD_ErrHnd added notification to __WD_Error #513

Merged

Danp2 reviewed Mar 2, 2024

View reviewed changes

Danp2 reviewed Mar 3, 2024

View reviewed changes

		; #FUNCTION# ====================================================================================================================
		; Name ..........: _WD_DownloadAsBinary

WinHttp.WinHttpRequest.5.1 usage #512

Are you sure you want to change the base?

WinHttp.WinHttpRequest.5.1 usage #512

Conversation

mlipok commented Feb 27, 2024

Pull request

Proposed changes

Checklist

Types of changes

What is the current behavior?

What is the new behavior?

Influences and relationship to other functionality

Additional context

System under test

Uh oh!

sven-seyfert commented Feb 27, 2024

Uh oh!

mlipok commented Feb 28, 2024

Uh oh!

sven-seyfert commented Feb 28, 2024

Uh oh!

mlipok commented Feb 29, 2024

Uh oh!

sven-seyfert commented Feb 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sven-seyfert Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

mlipok Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sven-seyfert Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

mlipok Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

mlipok Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

Danp2 left a comment

Choose a reason for hiding this comment

Uh oh!

sven-seyfert commented Mar 2, 2024

Uh oh!

mlipok commented Mar 2, 2024

Uh oh!

mlipok commented Mar 2, 2024

Uh oh!

mlipok commented Mar 3, 2024

Uh oh!

mlipok commented Mar 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Danp2 left a comment

Choose a reason for hiding this comment

Uh oh!

sven-seyfert commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mlipok Feb 29, 2024 •

edited

Loading

mlipok commented Mar 3, 2024 •

edited

Loading