Skip to content

Possible fix for height behavior. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DannyvanderJagt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Possible fix for height behavior. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Libraries/Components/Keyboard/KeyboardAvoidingView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const KeyboardAvoidingView = React.createClass({

subscriptions: ([]: Array<EmitterSubscription>),
frame: (null: ?Rect),
firstFrame: (null: ?Rect),

relativeKeyboardHeight(keyboardFrame: ScreenRect): number {
const frame = this.frame;
Expand Down Expand Up @@ -122,6 +123,9 @@ const KeyboardAvoidingView = React.createClass({
},

onLayout(event: LayoutEvent) {
if(!this.firstFrame){
this.firstFrame = event.nativeEvent.layout;
}
this.frame = event.nativeEvent.layout;
},

Expand Down Expand Up @@ -158,12 +162,12 @@ const KeyboardAvoidingView = React.createClass({
switch (behavior) {
case 'height':
let heightStyle;
if (this.frame) {
if (this.firstFrame) {
// Note that we only apply a height change when there is keyboard present,
// i.e. this.state.bottom is greater than 0. If we remove that condition,
// this.frame.height will never go back to its original value.
// When height changes, we need to disable flex.
heightStyle = {height: this.frame.height - this.state.bottom, flex: 0};
heightStyle = {height: this.firstFrame.height - this.state.bottom, flex: 0};
}
return (
<View ref={viewRef} style={[style, heightStyle]} onLayout={this.onLayout} {...props}>
Expand Down