System.Windows.Forms: Choose a size that fits what we'll draw, close #58 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anielVanNoord#58 We calculate the size of the calendar cell according to the selected font.
Contributor
|
Where do the extra 2 pixels come from? |
Contributor
Author
On the left with two pixels, on the right without. In my opinion, it looks more readable. |
Contributor
|
The one on the right looks more like the control in .NET Framework to me. I don't really like the idea of the layout decision being based on aesthetic judgement (I wouldn't be able to decide between those two images). But I'm not sure what I'd suggest instead. |
Contributor
Author
|
The version on the right looks more like the old behavior from the screenshot in README.MD I can use this version, then I'll just remove these 2 pixels. |
Contributor
Author
|
updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate the size of the calendar cell according to the selected font.