Add Nuget nupkg signing #11
Open
+62
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
reviewed
Dec 9, 2019
Owner
Daniel15
left a comment
Daniel15
left a comment
There was a problem hiding this comment.
Looks good, thanks! Just some minor comments inline.
| if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | ||
| { | ||
| await RunProcessAsync( | ||
| "mono", |
Owner
There was a problem hiding this comment.
Is Mono really needed here? Could it use .NET Core instead?
Author
There was a problem hiding this comment.
Unfortunately, it doesn't work in .NET Core yet. NuGet/NuGet.Client#2545
| $"-CertificatePath \"{CommandLineEncoder.Utils.EncodeArgText(certFile)}\"", | ||
| $"-CertificatePassword \"{CommandLineEncoder.Utils.EncodeArgText(certPassword)}\"", | ||
| $"-Timestamper {_pathConfig.Timestamper}", | ||
| $"\"{CommandLineEncoder.Utils.EncodeArgText(inputFile)}\"", |
Owner
There was a problem hiding this comment.
These arguments are all identical across both - Can you please remove the duplication (eg. pull them out into a separate array)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds .nupkg signing via
nuget signto Authenticode signing. nuget.exe needs to be installed on not-windows and path set to it. (Nuget still requires mono on other platforms.)I also made the timestamp service a configurable.