-
Notifications
You must be signed in to change notification settings - Fork 178
Add liveness and readiness probes for split brain detection container #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds configurable liveness and readiness probes for the split brain detection sidecar container in the Redis HA StatefulSet to improve monitoring and health checking capabilities.
Key Changes:
- Added liveness and readiness probe configuration to
splitBrainDetectionsection in values.yaml - Implemented probe definitions in the StatefulSet template for the split-brain-fix container
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/redis-ha/values.yaml | Added configuration parameters for liveness and readiness probes under splitBrainDetection section |
| charts/redis-ha/templates/redis-ha-statefulset.yaml | Implemented liveness and readiness probes for the split-brain-fix container using the new configuration values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@ninjatec This would be better done as a splitBrainDetection:
livenessProbe:
...Then: livenessProbe: {{ .Values.splitBrainDetection.livenessProbe | toYaml | nindent X }} |
|
I have updated the code in line with your suggestion |
Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com>
|
@ninjatec I fixed conflicts and removed the conditionals. They aren't needed. If you wanted to remove the Probes entirely, you can just do: |
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #367format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])