Skip to content

Conversation

@ninjatec
Copy link
Contributor

@ninjatec ninjatec commented Nov 12, 2025

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #367 format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Copilot AI review requested due to automatic review settings November 12, 2025 14:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable liveness and readiness probes for the split brain detection sidecar container in the Redis HA StatefulSet to improve monitoring and health checking capabilities.

Key Changes:

  • Added liveness and readiness probe configuration to splitBrainDetection section in values.yaml
  • Implemented probe definitions in the StatefulSet template for the split-brain-fix container

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
charts/redis-ha/values.yaml Added configuration parameters for liveness and readiness probes under splitBrainDetection section
charts/redis-ha/templates/redis-ha-statefulset.yaml Implemented liveness and readiness probes for the split-brain-fix container using the new configuration values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ninjatec and others added 3 commits November 14, 2025 09:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DandyDeveloper
Copy link
Owner

@ninjatec This would be better done as a toYaml inside the manifest, so you don't need the enable:

  splitBrainDetection:
    livenessProbe:
        ...

Then:

  livenessProbe: {{ .Values.splitBrainDetection.livenessProbe | toYaml | nindent X }}

@ninjatec
Copy link
Contributor Author

ninjatec commented Dec 2, 2025

I have updated the code in line with your suggestion

@DandyDeveloper
Copy link
Owner

@ninjatec I fixed conflicts and removed the conditionals. They aren't needed.

If you wanted to remove the Probes entirely, you can just do:

splitBrainDetection:
  livenessProbe: ~

@DandyDeveloper DandyDeveloper merged commit 931e88e into DandyDeveloper:master Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants