[stable/redis-ha] add sentinel announce-hosts and resolve-hosts #356
Conversation
Signed-off-by: Alex <alex.s@akeyless.io>
|
Hi @DandyDeveloper |
|
Hi @DandyDeveloper Is there anything else you need to move this PR forward? |
|
@Alex-Souslik @devopsmash Sorry for the delay, completely missed this. Looking over it and I'll have it merged today. |
| port: 26379 | ||
|
|
||
| ## Configure the 'bind' directive to bind to a list of network interfaces | ||
| bind: ~ |
There was a problem hiding this comment.
The previously missing key raised a nil pointer error in my IDE, the purpose was to explicitly define it (as nil)
Signed-off-by: Alex <alex.s@akeyless.io>
Signed-off-by: Alex <alex.s@akeyless.io>
Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: Alex <alex.s@akeyless.io>
#364) * fix(redis-ha): Correctly handle existing secret conditions for auth in ServiceAccount Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * chore(redis-ha): Bump chart version to 4.35.1 Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: Alex <alex.s@akeyless.io>
* fix(redis-ha): Standardize resource indentation for init containers in statefulset Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> * chore(redis-ha): Bump chart version to 4.35.2 Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> --------- Signed-off-by: Aaron Layfield <aaron.layfield@gmail.com> Signed-off-by: Alex <alex.s@akeyless.io>
Signed-off-by: Alex <alex.s@akeyless.io>
|
@DandyDeveloper Sorry, I had to re-sign off some of the commits |
Signed-off-by: Alex <alex.s@akeyless.io>
DandyDeveloper
dismissed
their stale review
The merge-base changed after approval.
Signed-off-by: Aaron Layfield <Aaron.Layfield@gmail.com>
|
@Alex-Souslik Can you grant me access to your fork? I'm trying to do some tests to make sure this is good but I can't checkout / clone your fork. |
|
@DandyDeveloper , merging is still blocked, anything I can do about it? |
|
@Alex-Souslik No, this isn't your fault. Sorry, entirely on me to just get your changes checked properly. I received the invite and didn't actually do my part. Thank you for the reminder, I'll have it done this evening my time. |
|
@Alex-Souslik Sorry, my home lab isn't working because my DNS is messed up. Need a bit more time, will repair tomorrow. |
|
@Alex-Souslik Got it all working and looks good. Sorry for the long delay. |
3 participants
What this PR does / why we need it:
sentinel announce-hostsandsentinel resolve-hostsenabling values.sentinel.confindentation.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])