Dynamic CI/CD UI Linking #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Added branch merging protection + Linting rules
* Created the linting rules for the project * Added path aliasing * Added the merge protection github action. * Addressed the multiline syntax Copilot highlighted
* Removed unnecessary label and emoji * Added protection for the main branch
Added main branch protection
* Removed unnecessary label and emoji * Added protection for the main branch * Implemented dynamic branch based import logic. * Ran lint fix * Fixed most of the linting errors. ESLint implementation errors remain * Fixed `createWasmCanvas.ts` ESLint implementation errors * Fixed `ProgramWindow.tsx` ESLint implementation errors * Fixed `WGPUNotificationWindow.tsx` ESLint implementation errors * Fixed `WalletContext.tsx` ESLint implementation errors * Fixed the `DrivesAndPrograms.tsx` ESLint implementation errors. Fixed aliased imports * Fixed the program window content not rendering and some ESLint implementation issues. * WASM rendering now works with remote files. * Added ignoring to the event that triggers the drive view. Fixed ESLint implementation error * Simplified the implementation of the assetLoader We now just use the headers available to the R2 bucket and get a speed boost! * Fixed copilot nitpicks * Made error name better
Dynamic Link Deployment Test - Dev Site (#7)
Dynamic CI/CD UI linking
Deploying daemon-os-ui-testnet with
|
| Latest commit: |
d80c1a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2eeacace.daemon-os-ui-testnet.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR implements dynamic CI/CD UI linking by refactoring URL constants from hardcoded values to dynamic environment-based configurations. The changes enable flexible deployment across different environments while improving code quality through modernization of TypeScript patterns and component structures.
Key Changes
- Centralized WASM asset URLs into environment-configurable constants
- Modernized TypeScript patterns and component syntax throughout the codebase
- Enhanced asset preloading system with unified validation and error handling
Reviewed Changes
Copilot reviewed 44 out of 52 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/assetPreloader.ts | Replaced hardcoded URLs with dynamic constants and simplified asset validation logic |
| src/components/ProgramEventDemo.tsx | Updated to use centralized WASM URL constants instead of hardcoded paths |
| src/components/ProgramDatabase.tsx | Migrated from hardcoded WASM URLs to dynamic configuration system |
| src/components/WasmIframeWrapper.tsx | Modernized component syntax and improved type safety |
| src/components/hooks/createWasmCanvas.ts | Enhanced TypeScript patterns and code formatting |
Comments suppressed due to low confidence (1)
src/components/Wallet/WalletApp.tsx:21
- The variable name '_e' is not descriptive. Consider using 'error' or 'parseError' for clarity.
} catch (_e) {
FloppyDisck
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.