Skip to content

Gcrone/resourcetree pybind#613

Merged
mroda88 merged 4 commits intodevelopfrom
gcrone/resourcetree-pybind
Feb 2, 2026
Merged

Gcrone/resourcetree pybind#613
mroda88 merged 4 commits intodevelopfrom
gcrone/resourcetree-pybind

Conversation

@gcrone
Copy link
Contributor

@gcrone gcrone commented Dec 9, 2025

Description

Update daqconf_inspector to display Resource tree following chain of ResourceSet's contained_resources method via new python binding (see DUNE-DAQ/confmodel#86). Also add new emoji to the set used to display enabled states for the category 'partially enabled' where a ResourceSet is enabled but it contains some Resources that are disabled.

Requires DUNE-DAQ/confmodel#86

To test:

daqconf_inspector sourcecode/daqsystemtest/config/daqsystemtest/example-configs.data.xml show-resources local-1x1-config root-segment

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@gcrone gcrone marked this pull request as draft December 9, 2025 15:26
@mroda88
Copy link
Contributor

mroda88 commented Dec 10, 2025

Let's make the PR against a patch branch

@gcrone gcrone changed the base branch from develop to patch/fddaq-v5.5.x December 10, 2025 11:14
@gcrone gcrone marked this pull request as ready for review January 13, 2026 10:42
@gcrone gcrone changed the base branch from patch/fddaq-v5.5.x to develop January 14, 2026 16:12
@mroda88 mroda88 added the good first issue Good for newcomers label Jan 15, 2026
Copy link
Contributor

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@mroda88 mroda88 merged commit b649e51 into develop Feb 2, 2026
3 checks passed
@mroda88 mroda88 deleted the gcrone/resourcetree-pybind branch February 2, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants