Skip to content

Conversation

@holke
Copy link
Collaborator

@holke holke commented Jan 16, 2026

Closes #2100

Describe your changes here:

Follow up to #2012 and related to #2008

Additionally to making external libraries aware of t8code being linked against VTK with #2012. we now also export the macros
T8CODE_VTK_VERSION_USED (now available in CMake scripts of external libraries) and
T8_VTK_VERSION_USED (now available in source code of external libraries).

Both have the same value.

(We could also have one name for both. I sticked to the existing naming scheme here and did both variants.)

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@holke holke added enhancement Enhances already existing code Follow-up PR priority:medium Should be solved within half a year workload:low Would take half a day or less labels Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.46%. Comparing base (63de7bd) to head (741ffdf).
⚠️ Report is 1 commits behind head on fix_vtk_linkage.

Additional details and impacted files
@@               Coverage Diff                @@
##           fix_vtk_linkage    #2099   +/-   ##
================================================
  Coverage            77.46%   77.46%           
================================================
  Files                  112      112           
  Lines                19084    19084           
================================================
  Hits                 14784    14784           
  Misses                4300     4300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix_vtk_linkage to main January 16, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances already existing code Follow-up PR priority:medium Should be solved within half a year workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants