-
Notifications
You must be signed in to change notification settings - Fork 18
Reducing API costs by filtering out binary files and other unwanted files #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0cddb3e
fixed the issue with the logo
vinyas-bharadwaj f25b3ac
Filters binary files in order to reduce API costs
vinyas-bharadwaj 32f7d9d
Merge branch 'DFanso:main' into main
vinyas-bharadwaj afbe485
Removed svg from the binary file filtering and fixed the rename/copy …
vinyas-bharadwaj e0752f3
Improved text file detection by checking common exesnsionless files l…
vinyas-bharadwaj 654dad4
Fixes parsing of git --name-status output by splitting lines on tabs …
vinyas-bharadwaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unquote name-status paths before classification/diffing
git diff --name-statusemits C-quoted paths whenevercore.quotepathis left at its (true) default—for example a binary fileimage file.pngshows up asM\t"image file.png". We forward that quoted string straight intoutils.IsBinaryFileand the latergit diff -- …call. Two bad things happen:.Ext("\"image file.png\"")yields.png", so we fail to recognise it as binary and end up sending the very data we meant to block.exec.Commandpasses the quotes verbatim, sogit diffnever matches the real path and the diff content silently disappears.Please strip the C-style quoting (and unescape sequences) before returning
filenames. A tiny helper aroundstrconv.Unquotefor both the rename/copy and regular branches fixes it:Without this, any path that needs quoting (spaces, non-ASCII, etc.) will either bypass the binary filter or vanish from the diff, defeating the main goal of the PR. -->
📝 Committable suggestion