-
Notifications
You must be signed in to change notification settings - Fork 18
Fix: Swap box corner strings #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughSwapped the box-drawing corner glyph assignments in ShowCommitMessage within internal/display/display.go so the top and bottom corners render in their correct positions. No other logic or exported declarations changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
internal/display/display.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build Go Binary (windows-latest)
DFanso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊
Fix inverted commit message panel corners
Description
┌┐and the bottom edge with└┘.internal/display/display.go.Type of Change
Related Issue
Fixes #77
Changes Made
ShowCommitMessage.ShowCommitMessage.Testing
Checklist
Screenshots (if applicable)
N/A
Additional Notes
Manual verification shows the commit message panel now displays with the correct orientation on Windows Terminal.
For Hacktoberfest Participants
Summary by CodeRabbit