Skip to content

Conversation

@Muneer320
Copy link
Contributor

@Muneer320 Muneer320 commented Oct 7, 2025

Fix inverted commit message panel corners

Description

  • Swap the commit message panel box-drawing corner characters so the top edge renders with ┌┐ and the bottom edge with └┘.
  • Aligns the styled panel output with the surrounding border characters in internal/display/display.go.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Other (please describe):

Related Issue

Fixes #77

Changes Made

  • Corrected the top-left and top-right corner strings in ShowCommitMessage.
  • Corrected the bottom-left and bottom-right corner strings in ShowCommitMessage.
  • Verified the panel renders with aligned corners during message preview.

Testing

  • Tested with Gemini API
  • Tested with Grok API
  • Tested on Windows
  • Tested on Linux
  • Tested on macOS
  • Added/updated tests (if applicable)

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have tested this in a real Git repository
  • I have read the CONTRIBUTING.md guidelines

Screenshots (if applicable)

N/A

Additional Notes

Manual verification shows the commit message panel now displays with the correct orientation on Windows Terminal.


For Hacktoberfest Participants

  • This PR is submitted as part of Hacktoberfest 2025

Summary by CodeRabbit

  • Style
    • Refined the commit message panel’s border rendering for improved visual consistency.
    • Corrected corner characters so panel corners display in the proper orientation across terminals.
    • UI polish only; no changes to behavior or functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Walkthrough

Swapped the box-drawing corner glyph assignments in ShowCommitMessage within internal/display/display.go so the top and bottom corners render in their correct positions. No other logic or exported declarations changed.

Changes

Cohort / File(s) Summary
Display panel corner glyphs
internal/display/display.go
Reassigned panel corner strings: top-left to "┌", top-right to "┐", bottom-left to "└", bottom-right to "┘" in ShowCommitMessage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge the corners, neat and tight,
From upside-down to just-right bright.
Boxes square, my whiskers twitch—
No flipped glyph plays a tricky switch.
Tap-tap keys; the borders sing—
Commit me joy, with proper ring. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of swapping the box corner strings, matching the core fix in the code. It is concise and free of extraneous detail, clearly indicating the nature of the bug fix. This makes it easily understandable to reviewers scanning the history.
Linked Issues Check ✅ Passed All objectives outlined in issue #77, including swapping the four corner glyph assignments and ensuring correct top-left, top-right, bottom-left, and bottom-right characters, are fully addressed by the changes in ShowCommitMessage. The code modifications align precisely with the proposed solution and the expected behavior. The fix has been validated in the target environment, meeting the linked issue’s requirements.
Out of Scope Changes Check ✅ Passed The pull request only alters the corner glyph assignments within ShowCommitMessage in internal/display/display.go, with no additional modifications to unrelated code. All changes directly relate to the bug fix described in the linked issue. No new files or extraneous logic were introduced outside the scope of the intended correction.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2726ec and 0fe528b.

📒 Files selected for processing (1)
  • internal/display/display.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build Go Binary (windows-latest)

@DFanso DFanso self-requested a review October 7, 2025 19:23
Copy link
Owner

@DFanso DFanso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@DFanso DFanso merged commit d7e49ab into DFanso:main Oct 7, 2025
8 checks passed
@DFanso DFanso added bug Something isn't working good first issue Good for newcomers hacktoberfest Eligible for Hacktoberfest hacktoberfest-accepted Approved Hacktoberfest contribution go Pull requests that update go code labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code good first issue Good for newcomers hacktoberfest Eligible for Hacktoberfest hacktoberfest-accepted Approved Hacktoberfest contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Commit message panel renders with inverted corner glyphs

2 participants