Skip to content

fix #72 : Replace hardcoded display limits with named constants in ShowFileStatistics #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DFanso merged 2 commits into from
Oct 7, 2025
Merged

fix #72 : Replace hardcoded display limits with named constants in ShowFileStatistics #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1814b20
fix #72 : Replace hardcoded display limits with named constants in Sh…
adeeshperera Oct 7, 2025
2520073
Merge pull request #7 from adeeshperera/Replace-hardcoded
adeeshperera Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions internal/display/display.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ import (
"github.com/pterm/pterm"
)

const (
MaxStagedFiles = 5
MaxUnstagedFiles = 3
MaxUntrackedFiles = 3
)

// FileStatistics holds statistics about changed files
type FileStatistics struct {
StagedFiles []string
Expand All @@ -31,17 +37,17 @@ func ShowFileStatistics(stats *FileStatistics) {
BulletStyle: pterm.NewStyle(pterm.FgGreen),
})
for i, file := range stats.StagedFiles {
if i < 5 { // Show first 5 files
if i < MaxStagedFiles { // Show first 5 files
bulletItems = append(bulletItems, pterm.BulletListItem{
Level: 1,
Text: file,
})
}
}
if len(stats.StagedFiles) > 5 {
if len(stats.StagedFiles) > MaxStagedFiles {
bulletItems = append(bulletItems, pterm.BulletListItem{
Level: 1,
Text: pterm.Gray(fmt.Sprintf("... and %d more", len(stats.StagedFiles)-5)),
Text: pterm.Gray(fmt.Sprintf("... and %d more", len(stats.StagedFiles)-MaxStagedFiles)),
})
}
}
Expand All @@ -54,17 +60,17 @@ func ShowFileStatistics(stats *FileStatistics) {
BulletStyle: pterm.NewStyle(pterm.FgYellow),
})
for i, file := range stats.UnstagedFiles {
if i < 3 {
if i < MaxUnstagedFiles {
bulletItems = append(bulletItems, pterm.BulletListItem{
Level: 1,
Text: file,
})
}
}
if len(stats.UnstagedFiles) > 3 {
if len(stats.UnstagedFiles) > MaxUnstagedFiles {
bulletItems = append(bulletItems, pterm.BulletListItem{
Level: 1,
Text: pterm.Gray(fmt.Sprintf("... and %d more", len(stats.UnstagedFiles)-3)),
Text: pterm.Gray(fmt.Sprintf("... and %d more", len(stats.UnstagedFiles)-MaxUnstagedFiles)),
})
}
}
Expand All @@ -77,17 +83,17 @@ func ShowFileStatistics(stats *FileStatistics) {
BulletStyle: pterm.NewStyle(pterm.FgCyan),
})
for i, file := range stats.UntrackedFiles {
if i < 3 {
if i < MaxUntrackedFiles {
bulletItems = append(bulletItems, pterm.BulletListItem{
Level: 1,
Text: file,
})
}
}
if len(stats.UntrackedFiles) > 3 {
if len(stats.UntrackedFiles) > MaxUntrackedFiles {
bulletItems = append(bulletItems, pterm.BulletListItem{
Level: 1,
Text: pterm.Gray(fmt.Sprintf("... and %d more", len(stats.UntrackedFiles)-3)),
Text: pterm.Gray(fmt.Sprintf("... and %d more", len(stats.UntrackedFiles)-MaxUntrackedFiles)),
})
}
}
Expand Down
Loading