Skip to content

Add Liechtenstein bank holidays 2026 and prevent fiat output on holidays #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TaprootFreak wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add Liechtenstein bank holidays 2026 and prevent fiat output on holidays #2779

TaprootFreak wants to merge 4 commits into from

Conversation

@TaprootFreak
Copy link
Collaborator

@TaprootFreak TaprootFreak commented Dec 31, 2025 •
edited
Loading

Summary

  • Add Liechtenstein bank holidays configuration for 2026
  • Prevent fiat outputs with LI IBANs and LiqManagement type from getting isReadyDate on Liechtenstein bank holidays
  • Block transactions on day before bank holiday after 16:00 (LI IBANs with LiqManagement type only)

Changes

  • New file: liechtenstein-bank-holiday.config.ts with all 2026 Liechtenstein bank holidays
  • Updated fiat-output-job.service.ts to check Liechtenstein bank holidays for LI IBANs with type LiqManagement
  • Only FiatOutputs with LI IBAN AND type=LiqManagement are affected by holiday checks
  • Other IBAN countries and other FiatOutput types are not affected

Test plan

  • Verify LI IBANs with type LiqManagement don't get isReadyDate on Liechtenstein bank holidays
  • Verify LI IBANs with type LiqManagement don't get isReadyDate after 16:00 on day before Liechtenstein bank holiday
  • Verify LI IBANs with other types (BuyFiat, etc.) are not affected
  • Verify CH and other IBANs are not affected by Liechtenstein bank holidays

@TaprootFreak
Add Liechtenstein bank holidays 2026 and prevent fiat output on holidays
79c6b98 
- Add liechtenstein-bank-holiday.config.ts with 2026 holidays
- Update fiat-output-job.service to check for LI/CH bank holidays
- Block isReadyDate on bank holidays and day before after 16:00
@TaprootFreak
Restrict bank holiday check to LI IBANs only
7d539f4 
- Bank holiday blocking now only applies to Liechtenstein IBANs
- CH and other IBANs are not affected by holiday checks
- Remove unused isBankHoliday import
@TaprootFreak
Restrict bank holiday check to LiqManagement type only
2d3eedf 
- Bank holiday blocking now only applies to FiatOutputs with type LiqManagement
- Other types (BuyFiat, BuyCryptoFail, etc.) are not affected
@TaprootFreak
Improve bank holiday check implementation
1cd3fc1 
- Add verbose logging when FiatOutput is blocked due to bank holiday
- Use early return (continue) for better readability
- Only calculate isAfter16 when actually needed (performance)
- Clearer variable scoping and logic flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yannick1712 Yannick1712 Awaiting requested review from Yannick1712

@davidleomay davidleomay Awaiting requested review from davidleomay

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaprootFreak