Fix email UX: display button before fallback link #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, emails display the URL link first, followed by the button. This creates a poor user experience as most users can see buttons, making the link redundant for the majority. Changes: - Reorder email content to show button first, then link - Update all translations (de/en/pt) to reflect new order - Add "or" prefix to link text to indicate it's a fallback option Affected emails: - Login email (auth.service.ts) - KYC reminder, failed, and missing data emails (kyc-notification.service.ts) - Account merge request email (account-merge.service.ts) This improves UX by prioritizing the primary action (button) and making the plain-text link available only for clients that don't support buttons.
TaprootFreak
force-pushed
the
fix/email-button-link-order
branch
from
587ae9c to
e7dce33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Email templates currently display content in a suboptimal order:
This creates confusion because:
Solution
Reorder email content to prioritize the button:
Changes
Code changes
auth.service.ts- Login email: button before linkkyc-notification.service.ts- KYC emails (reminder, failed, missing data): button before linkaccount-merge.service.ts- Account merge request: button before linkTranslation changes (de/en/pt/fr/it/es)
general.button- Removed "or" prefix (now primary action)login.message- Added "or" prefix to link textkyc.retry- Added "or" prefix to link textkyc.next_step- Fixed to avoid double "or" (kept original text structure)account_merge.request.message- Added "or" prefix to link textNote: Albanian (sq) has no mail.json file and was skipped.
Verified correct order already
These notification services already had the correct button-first order and required no changes:
bank-tx-return-notification.service.tsbuy-fiat-notification.service.tsbuy-crypto-notification.service.tstransaction-notification.service.tsrecommendation.service.tsImpact
Test plan