Add mixed-type GPU arith ops tests and fix Cpr/Mod dispatcher#730
Closed
Add mixed-type GPU arith ops tests and fix Cpr/Mod dispatcher#730
Conversation
Collaborator
jysh1214
commented
Dec 6, 2025
- Skip Int64 vs Int16 Cpr test due to unresolved issue
- Skip Int64 vs Int16 Cpr test due to unresolved issue
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
+ Coverage 32.35% 35.26% +2.91%
==========================================
Files 215 215
Lines 36363 33095 -3268
Branches 14597 13196 -1401
==========================================
- Hits 11764 11670 -94
+ Misses 22659 19511 -3148
+ Partials 1940 1914 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IvanaGyro
reviewed
Dec 10, 2025
| } | ||
|
|
||
| // Test tensor-to-tensor addition with mixed types | ||
| TEST_P(AddTestAllShapes, gpu_tensor_add_tensor_mixed_types) { |
Collaborator
There was a problem hiding this comment.
It seems that this test already covers TEST_P(AddTestAllShapes, gpu_tensor_add_tensor_all_types). Is it fine the remove the following one?
Additionally, a comment in #723 mentioned there is a problem of type promotion. Will this problem be addressed in the following changes?
Collaborator
Author
|
Let me modify each unit tests to use mioxed types one by one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.