Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for OS-specific steps and refactors configuration handling by removing the WorkspaceConfig dependency in favor of a simpler Config interface. Key changes include:
- Removal of the WorkspaceConfig parameter from UseCaseRunner, ContextCreator, and RepositoriesRepository.
- Updates in TemplatesAccess to use a new Config interface and adjustment of repository URL creation.
- Changes to configuration loading and command modules (sync, run, init) to ensure proper config extraction and the introduction of a debug option.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/use-cases/use-case-runner.ts | Removed config parameter; updated ContextCreator creation method. |
| src/services/use-cases/context-creator.ts | Updated create method signature and added OS property to context. |
| src/services/repositories.repository.ts | Removed config parameter and updated repository URL creation. |
| src/services/access/templates-access.ts | Changed to use Config interface; updated property access accordingly. |
| src/config.ts | Refactored config loading to return a plain config store in certain cases. |
| src/commands/sync/sync.ts | Updated call to UseCaseRunner.create to match new parameter signature. |
| src/commands/run/run.ts | Added debug option and adjusted config loading accordingly. |
| src/commands/init/action.ts | Updated config usage with config.store for TemplatesAccess creation. |
| README.md | Updated documentation to add the new debug option and OS property. |
Files not reviewed (1)
- assets/templates/config/use-cases/check-requirements.json: Language not supported
Comments suppressed due to low confidence (2)
src/config.ts:74
- The function loadWorkspaceConfig now returns config.store instead of the full Conf instance. Please ensure that all consuming modules correctly handle the change to a plain config object to avoid type mismatches.
return loadConfig(workspacePath).store;
src/commands/init/action.ts:68
- The usage of config.store here differs from other commands (where a plain config object is already expected). Please verify that converting the Conf instance to a plain object in init aligns with the overall configuration handling strategy.
const templatesAccess = TemplatesAccess.create(config.store);
3b6a5ab to
56edf51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information