Skip to content

gh-27 Fix Windows path problem without refactor #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bicschneider wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gh-27 Fix Windows path problem without refactor #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/customatics/leaptest_plugin/PluginHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ public void createJUnitReport(FilePath workspace, String JUnitReportFile, final
if(workspace.isRemote())
{
VirtualChannel channel = workspace.getChannel();
reportFile = new FilePath(channel, Paths.get(workspace.toURI().getPath(), JUnitReportFile).toString());
reportFile = new FilePath(channel, workspace.toURI().getPath() + "/" + JUnitReportFile);
Copy link
Contributor

@romanchetto romanchetto Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will try it on Windows and Linux using File.separator instead of "/". If succeed, maybe, will be changed in the next update. But I still don't understand why this issue happens on Windows system considering documentation for Paths.get method:

  1. https://docs.oracle.com/javase/7/docs/api/java/nio/file/Paths.html
  2. http://www.java2s.com/Tutorials/Java/java.nio.file/Paths/Java_Paths_get_String_first_String_more_.htm

listener.getLogger().println(String.format(Messages.FULL_REPORT_FILE_PATH,reportFile.toURI().getPath()));
}
else
Expand Down