fix: elixir v1.19 compatible struct update syntax #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) do | ||
| {ref, state} = State.next_ref(state) | ||
| state = %State{state | joins: Map.put(state.joins, cmd.topic, ref)} | ||
| %State{} = state = %{state | joins: Map.put(state.joins, cmd.topic, ref)} |
Collaborator
There was a problem hiding this comment.
For these clauses of handle_message/1, rather than matching %State{} as the return value, shouldn't we match in the function parameters?
defp handle_message(%{message: command(%Commands.JoinTopic{} = cmd), state: %State{} = state}) do
# ..
endI haven't been following the type system stuff lately but I would assume that this would give the type system a better hint about the original state binding, and it would know that state.joins exists on this line for example. And that state.config exists in clauses below, like the one for %Events.ChannelConnected{}
Contributor
Author
There was a problem hiding this comment.
Yeah pattern matching in the head is probably a better thing to do,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir v1.19 deprecates struct update syntax:
elixir-lang/elixir#13974
Just using map update syntax doesn't change the type of the struct, (thats still stored in the data of the map effectively), and this behaviour was always allowed for structs. It's just that elixir has decided to go forward with one syntax and build type checking features around it.
This pr removes a bunch of warnings that occur when compiling slipstream with v1.19 but still works in v1.17.