Add an API Request Service task to process #300
Conversation
Hiro-Nakamura
left a comment
Hiro-Nakamura
left a comment
There was a problem hiding this comment.
Nice Job.
Just a few questions to think through...
| id: ids.suggest, | ||
| view: "mentionsuggest", | ||
| symbol: "<", | ||
| template: "%= #value# %>", |
There was a problem hiding this comment.
Should this template: start with "<%= ..." ?
or does the symbol: "<" do something with this?
There was a problem hiding this comment.
Yes, the way the webix autocomplete works the "<" will already be there, so adding it to the template would output <<%=... in the text.
| values.deleteSecrets = this.deleteSecrets; | ||
| delete this.deleteSecrets; | ||
| } | ||
| console.log("VALUES", values); |
There was a problem hiding this comment.
should probably not be dumping this on the console.
| * @param {string} [header.value] | ||
| */ | ||
| addHeader(header = {}) { | ||
| const uid = AB.Webix.uid(); //this is unique to the page |
There was a problem hiding this comment.
Hey, thinking about Cypress testing here ... should we use more guessable uids here ... like the header.value, header.header, or a combo: header.header-header.value. so that if we do write tests for this, we can more easily guess and reference these fields?
| * @param {object} [obj={}] - The object to modify (or a new object if not provided). | ||
| * @returns {object} The modified object with the nested value. | ||
| */ | ||
| function nestValue(key, value, obj = {}) { |
3 participants
Release Notes
Test Status
No test yet, tested locally.
Todo
📝 Not Feature Complete, but enough functionality for webhooks