Skip to content

New property managers for adding a Timeline widget to the PWA platform #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hiro-Nakamura merged 2 commits into from
Feb 17, 2025
Merged

New property managers for adding a Timeline widget to the PWA platform #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1989a
[add] new property managers for adding a Timeline widget to the PWA p…
Hiro-Nakamura Feb 7, 2025
c233b4a
Merge commit 'ec2fa1d342116f79512fc1e9bd44bb47a2f2d5e3' into jh/pwaTi…
Hiro-Nakamura Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/rootPages/Designer/properties/PropertyManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ export default function (AB) {
require("./mobile/ABMobileViewFormTextbox"),
require("./mobile/ABMobileViewLabel"),
require("./mobile/ABMobileViewList"),
require("./mobile/ABMobileViewTimeline"),
].forEach((V) => {
MobileViews.push(V.default(AB));
});
Expand Down
16 changes: 8 additions & 8 deletions src/rootPages/Designer/properties/mobile/ABMobileViewForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,15 +685,15 @@ export default function (AB) {
yPosition
);
// @TODO: filter out unknown mobile-view
if (!newFieldView) return;
if (newFieldView.defaults.key == "mobile-view") return;
if (newFieldView) {
newFieldView.once("destroyed", () =>
this.populate(currView)
);

// // Call save API
saveTasks.push(newFieldView.save());
}

newFieldView.once("destroyed", () =>
this.populate(currView)
);

// // Call save API
saveTasks.push(newFieldView.save());

// update item to UI list
f.selected = 1;
Expand Down
Loading
Loading