Skip to content

ensure proper quoting around SQL DATE() conditions #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pong-promrat merged 2 commits into from
Jan 30, 2026
+5 −4
Merged

ensure proper quoting around SQL DATE() conditions #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f6cde4
[fix] ensure proper quoting around DATE() sql conditions
johnny-hausman Jan 29, 2026
34ec627
Merge commit 'e10c58637da01294da0da1d4a6fac6ad207698d1' into jh/james…
johnny-hausman Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions platform/ABModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,8 +1231,9 @@ module.exports = class ABModel extends ABModelCore {
condition.rule != "next_days" &&
condition.rule != "is_current_date"
) {
condition.key = `DATE(${condition.key})`;
condition.key = `DATE("${condition.key}")`;
condition.value = `DATE("${condition.value}")`;
skipQuotes = true;
}

// Search string value of FK column
Expand Down Expand Up @@ -1302,7 +1303,7 @@ module.exports = class ABModel extends ABModelCore {
like: "LIKE",
};

// normal field name:
// normal field name: ... or DATE(...)
var columnName = condition.key;
if (typeof columnName == "string" && !skipQuotes) {
// make sure to ` ` columnName (if it isn't our special '1' condition )
Expand Down Expand Up @@ -1337,8 +1338,8 @@ module.exports = class ABModel extends ABModelCore {
var operator = conversionHash[condition.rule];
var value = condition.value;

// If a function, then ignore quote. like DATE('05-05-2020')
if (!RegExp("^[A-Z]+[(].*[)]$").test(value)) {
// If a function, then ignore quote. e.g. DATE('05-05-2020') or DATE(829c8d74.Ended)
if (!/^[A-Z][A-Z0-9]*\([^)]*\)$/.test(value)) {
value = quoteMe(value);
}

Expand Down
Loading